Change relevant pet fields to getters #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For pet type class methods that just return private values, replace the methods with getter methods so that the fields can be accessed on the pets without parentheses. E.g. `pet.name` instead of `pet.name()`
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
======================================
Coverage 8.35% 8.35%
======================================
Files 3 3
Lines 634 634
Branches 90 90
======================================
Hits 53 53
Misses 581 581
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tonybaloney
approved these changes
Oct 21, 2022
|
Thanks! |
tonybaloney
added a commit
that referenced
this pull request
Feb 26, 2023
Change relevant pet fields to getters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pet type class methods that just return private values, replace the methods with getter methods so that the fields can be accessed on the pets without parentheses.
E.g.
pet.nameinstead ofpet.name()This is a followup to #285