Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erlang compatibility for List Pattern Matching #1615

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Erlang compatibility for List Pattern Matching #1615

merged 2 commits into from
Nov 4, 2024

Conversation

m-2k
Copy link
Contributor

@m-2k m-2k commented Oct 16, 2024

Exclude ligatures for [_|_] [_,_|_] [ _|_ ] [ _, _|_ ] from underscores lookup

Screenshot 2024-10-16 at 18 22 50

@m-2k
Copy link
Contributor Author

m-2k commented Oct 21, 2024

how long will it take to merge?

@tonsky
Copy link
Owner

tonsky commented Oct 21, 2024

I don’t think I like inclusion of space in the ignore pattern. You’ll write it either as [_|_] or [ _ | _ ], no? With just [bracket comma] underscore I can add it

@m-2k
Copy link
Contributor Author

m-2k commented Oct 30, 2024

@tonsky

Screenshot 2024-10-30 at 18 48 48

@tonsky tonsky merged commit 259ea72 into tonsky:master Nov 4, 2024
@tonsky
Copy link
Owner

tonsky commented Nov 4, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-2k @tonsky