Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendering of !!!!!! #110

Closed
xcambar opened this issue Jan 13, 2016 · 9 comments
Closed

rendering of !!!!!! #110

xcambar opened this issue Jan 13, 2016 · 9 comments

Comments

@xcambar
Copy link

xcambar commented Jan 13, 2016

Rendering !!!!!! (6 exclamation marks with no space) renders as follows:

screen shot 2016-01-13 at 15 16 46

There's a clear impression of two groups of 3 spaces, when it's one group of 6.

Note that this effect works for any group of exclamation marks > 3 characters.

@MadcapJake
Copy link

There's only a ligature for three exclamation marks.

@tonsky
Copy link
Owner

tonsky commented Jan 13, 2016

i'll address that in next version

On Wed, Jan 13, 2016 at 8:52 PM Jake Russo [email protected] wrote:

There's only a ligature for three exclamation marks.


Reply to this email directly or view it on GitHub
#110 (comment).

@federicobond
Copy link

This group by 3 behavior is also present in dashes.

The case of equals signs, commonly used to underline Markdown headings is actually worse, because 3 consecutive equals turn into a symbol with 3 horizontal lines instead of two.

captura de pantalla 2016-03-03 a las 3 40 39 p m

@curio77
Copy link

curio77 commented Mar 15, 2016

Long sequences of slashes (“///////////////////…”, used by some as visual delimiters in source code) also get rendered as groups of three, not sure if anything can be done about this?

@tonsky
Copy link
Owner

tonsky commented Mar 15, 2016

Yes, I can block sequences longer than 3 slashes or exclamations marks from
forming a ligature altogether. I’m planning this for the next version.

On Tue, Mar 15, 2016 at 10:01 AM curio77 [email protected] wrote:

Long sequences of slashes (“///////////////////…”, used by some as visual
delimiters in source code) also get rendered as groups of three, not sure
if anything can be done about this?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#110 (comment)

@curio77
Copy link

curio77 commented Mar 15, 2016

That's great! And I very much enjoy working with Fira Code within both Atom and Android Studio/IntelliJ IDEA, so many thanks for it! :-)

@stephencelis
Copy link

Please do the same for ...! A lot of test runners use dots to denote passing test cases.

@engelfrost
Copy link

I think this behavior is wanted for all sequences of identical characters.

@Jessidhia
Copy link

Indeed. Sequences of w are another fun case:

Though one might question my decision of using Fira Code as an IRC font.

@tonsky tonsky closed this as completed in 08c4dd5 Jul 17, 2016
tonsky added a commit that referenced this issue Jul 17, 2016
- New `calt` code disables ligatures on long sequences, e.g. `!!!!`,
  `>>>>`, etc (closes #49, closes #110, closes #176)
Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants