fix darwin build and make sure it is enabled on cross #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Closed
|
nit: add |
|
@crazy-max can we do this in another PR. I couldn't avoid it for the files I changed because of my local editor configuration. |
|
@tonistiigi Sure. I pushed a commit to your branch with the ci changes related to macos instead of the other PR. |
Signed-off-by: CrazyMax <[email protected]>
crazy-max
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this broke in #109 and surprisingly darwin target was missing in cross and didn't catch it
@akhramov
@crazy-max When you have free cycles feel free to add direct darwin worker(and windows if possible) in CI to run
go test. I thought this was already the case but looks like freebsd is the only special case.