Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparations to publish wireguard-control, netlink-request #321

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

strohel
Copy link
Member

@strohel strohel commented Sep 5, 2024

Specify version for the netlink-request dependency in wireguard-control

(Try to) make netlink-request publishable

Change netlink-request license to MIT

Previous LGPL-2.1-or-later was a copy-paste error from wireguard-control. I unfortunately published it that way to creates.io...

Update README with a note on publishing to crates.io


A helper to perform requests using the Linux netlink interface.

Versioning is held in lockstep with innernet, although this may change in the future.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, it would make sense to edit https://github.com/tonarino/innernet/blob/main/release.sh to handle netlink-request/Cargo.toml the same way as wireguard-control/Cargo.toml to ensure the version is locked in step.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to this being the easiest direction to take it.

As a future thought, these libraries are less married to the development of innernet directly, so there may be more cases in the future where you'd want to push a fix for netlink-request without needing to update the innernet semver at the same time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, added to release.sh in 3703001, I've manually checked that the perl command works.

On a slightly unrelated note, I think cargo release can now supply many duties we do manually in release.sh (replacing versions, committing, tagging). I see we have that disabled in release.toml. At some point we may revisit that.

Copy link
Collaborator

@mcginty mcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides @goodhoko's note about updating release.sh, looks good.

Copy link
Member

@goodhoko goodhoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レムイᄊ

@strohel strohel merged commit 0c08d95 into main Sep 13, 2024
9 checks passed
@strohel strohel deleted the publish-crates branch September 13, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants