Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#277 - add gcc, change dnf to yum #278

Merged
merged 1 commit into from
Jul 11, 2023
Merged

#277 - add gcc, change dnf to yum #278

merged 1 commit into from
Jul 11, 2023

Conversation

wwalker
Copy link
Contributor

@wwalker wwalker commented Jul 8, 2023

  • add the gcc package to the packages to add to the docker image for build
  • change dnf to yum. (systems that use dnf always have yum and the basic yum/dnf commands are identical)
  • I have built packages for Fedora 37,38 and CentOS 7 with this fix applied

Copy link
Collaborator

@mcginty mcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Alma also for sanity with another modern redhat derivatives and seems fine!

Copy link
Member

@strohel strohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM. With .deb package we've actually transitoned away from providing them within our repository - an external build/repository by a community member is now provided itself.

With RPMs we probably don't need to remove what's working, but I wonder @wwalker if you'd be interesting in maintaining an external RPM build/repository for innernet?

@wwalker
Copy link
Contributor Author

wwalker commented Jul 10, 2023

I can probably do that. I'll get back on this in the next two days.

@strohel strohel merged commit 864c83c into tonarino:main Jul 11, 2023
@strohel
Copy link
Member

strohel commented Jul 11, 2023

I can probably do that. I'll get back on this in the next two days.

🙏 🙏 🙏 In the mean time I've merged this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants