Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Remove typings #27

Merged
merged 3 commits into from
Feb 13, 2017
Merged

Remove typings #27

merged 3 commits into from
Feb 13, 2017

Conversation

TheKeithStewart
Copy link
Collaborator

No description provided.

@tomwayson tomwayson self-assigned this Feb 5, 2017
@tomwayson
Copy link
Owner

Thanks for this @kgs916.

One thing I'm wondering is if angular2-esri4-components should declare @types/arcgis-js-api as a dependency instead of a devDependency - then consuming apps would not have to manually add the types to their devDependencies. I searched a bit to see what the norm in the TS community is and (no surprise) it seems like conventions are still forming around this. The most useful discussion I found was this: microsoft/types-publisher#81 (comment) which indicates that libraries should declare their types as dependencies. However, others on that thread bring up good points about not being able to find any examples of that and the potential for two of an apps dependencies to depend on different versions of a library like the ArcGIS API.

After reading that discussion, I tend to lean towards angular2-esri4-components declaring @types/arcgis-js-api as a dependency instead of a devDependency so that consuming apps such as this do not need to do it themselves. What do you think?

Also cc'ing people that, unlike me, actually use TypeScript: @patrickarlt @dasa @odoe

@dasa
Copy link

dasa commented Feb 12, 2017

After reading that discussion, I tend to lean towards angular2-esri4-components declaring @types/arcgis-js-api as a dependency instead of a devDependency so that consuming apps such as this do not need to do it themselves. What do you think?

That sounds good 👍

@TheKeithStewart
Copy link
Collaborator Author

Thanks for the feedback @tomwayson and @dasa! I'll make the change in angular2-esri4-components to reflect this and update this PR.

@TheKeithStewart
Copy link
Collaborator Author

@tomwayson, I've moved @types/archgis-js-api to the dependencies for angular2-esri4-components and added a new commit that removes it from the devDependencies here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants