Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support? #4

Closed
tomrijndorp opened this issue Jun 27, 2021 · 3 comments
Closed

Windows support? #4

tomrijndorp opened this issue Jun 27, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested windows

Comments

@tomrijndorp
Copy link
Owner

tomrijndorp commented Jun 27, 2021

Also see #2. I think there are two options:

  1. Invoke the bash scripts from Windows. I'm not sure how / whether this can be done. Will require WSL to be installed. Not sure if there are further issues with access permissions etc. Will require some investigation.
  2. Create Windows versions of find_files.sh and find_within_files.sh (the scripts in the extension that invoke fzf). This may be the nicest solution as it's a native implementation, but requires Windows shell scripting, which I'm not familiar at all.

If you're a Windows user, please vote on this ticket using 🚀 for the first solution, 🎉 for the second, or 😕 for don't know / don't care as long as you do something. Votes will compel me to take action (and learn windows batch file scripting).

If you're interested in implementing solution 2 and supporting it, please shoot me a message! The extension is built in such a way that implementing this solution requires writing two scripts that invoke the terminal commands, and there are reference implementations in bash shell script.

@tomrijndorp tomrijndorp added enhancement New feature or request good first issue Good for newcomers question Further information is requested labels Jun 27, 2021
@marblewraith
Copy link

Not a user of this, but i thought i'd provide a bit of rambling which may help.

  1. Ripgrep was internalized into VScode some time ago see package.json.

  2. FZF is tricker. The simplest install is the binaries via chocolatey or scoop. But IMO before you added win support here, fzf should be added to winget since that ships by default win11, related issues here:

@ihdavids
Copy link
Collaborator

#18
I just downloaded the windows versions of bat, fzf and ripgrep. The extension scripts are all powershell scripts.

@tomrijndorp
Copy link
Owner Author

Native Windows support is implemented as of version 0.0.20 now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested windows
Projects
None yet
Development

No branches or pull requests

3 participants