Support loading types asynchronously #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
reviewed
May 31, 2023
To avoid the "Stop the world" on loading types, this allows to load
types asynchronously.
Users can change the types loader via `KatakataIrb::Types.loader_type`
setting:
KatakataIrb::Types.loader_type = :async
tk0miya
force-pushed
the
async_rbs_builder_loader
branch
from
b68bbc2 to
e578679
Compare
|
Now I updated my PR. Thank you for your review! |
tk0miya
added a commit
to tk0miya/katakata_irb
that referenced
this pull request
Jun 30, 2023
`rbs_builder_loader` was already removed on the review at tompng#15. Therefore it should be removed too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid the "Stop the world" on loading types, this allows to load types asynchronously.
Users can change the types loader via
KatakataIrb::Types.loader_typesetting: