Regenerate client against openapi-generator v4.3.0 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of openapi-generator includes a fix to make asyncio-based Python clients explicitly closable and usable within an asynchronous context manager. This commit regenerates the client against openapi-generator v4.3.0 and updates the commit hash in scripts/update-client.sh.
scripts/update-client.sh was failing to run properly due to
.. literals in path names and missing rgrep. This commit uses dirname
in place of ${SCRIPT_ROOT}/.. and `grep -r` in place of rgrep.
tomplus
reviewed
Mar 31, 2020
Comment on lines
+631
to
+634
| *CustomObjectsApi* | [**delete_cluster_custom_object**](docs/CustomObjectsApi.md#delete_cluster_custom_object) | **DELETE** /apis/{group}/{version}/{plural} | | ||
| *CustomObjectsApi* | [**delete_cluster_custom_object_0**](docs/CustomObjectsApi.md#delete_cluster_custom_object_0) | **DELETE** /apis/{group}/{version}/{plural}/{name} | | ||
| *CustomObjectsApi* | [**delete_namespaced_custom_object**](docs/CustomObjectsApi.md#delete_namespaced_custom_object) | **DELETE** /apis/{group}/{version}/namespaces/{namespace}/{plural} | | ||
| *CustomObjectsApi* | [**delete_namespaced_custom_object_0**](docs/CustomObjectsApi.md#delete_namespaced_custom_object_0) | **DELETE** /apis/{group}/{version}/namespaces/{namespace}/{plural}/{name} | |
There was a problem hiding this comment.
It's introduced by kubernetes-client/gen#150 and we can leave it as is.
|
@tomplus Just checking in on this; let me know if you need anything further for the PR. |
tomplus
approved these changes
Apr 12, 2020
|
Your change has been released in v11.2.0. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently ran into #91 and saw that OpenAPITools/openapi-generator#5621 had just been merged, which is great! Since I could use this feature, I thought I would try regenerating the client myself against openapi-generator v4.3.0.
Two things are important here (besides the fact that the client has been regenerated):
delete_cluster_custom_objectanddelete_namespaced_custom_object. I'm not sure why, but I'm happy to look into it. (EDIT: It looks like these are also in the generated source, which isn't great.)Beyond that, the client seems to work for my case, and the warnings about unawaited coroutines have gone away.