feat: use openapi-generator to generate client #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomplus
commented
Jan 11, 2019
| @@ -1,2 +0,0 @@ | |||
| Requested Commit: f9b2839a3076f26db1b8fc61655a26662f2552ee | |||
There was a problem hiding this comment.
I had to delete kubernetes_asyncio/.swagger-codegen and rename kubernetes_asyncio/.swagger-codegen-ignore to kubernetes_asyncio/.openapi-generator-ignore.
tomplus
commented
Jan 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=========================================
Coverage ? 94.39%
=========================================
Files ? 20
Lines ? 1355
Branches ? 0
=========================================
Hits ? 1279
Misses ? 76
Partials ? 0Continue to review full report at Codecov.
|
tomplus
commented
Jan 21, 2019
| @@ -61,6 +61,7 @@ def __aiter__(self): | |||
| with patch('kubernetes_asyncio.client.api_client.rest', mock): | |||
|
|
|||
| api_client = WsApiClient() | |||
| api_client.configuration.host = 'https://localhost' | |||
There was a problem hiding this comment.
because the openapi-generator uses http://localhost as a default hostname and the swagger-codegen used https://localhost.
There was a problem hiding this comment.
tomplus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were generated by openapi-generator instead of swagger-codegen.
Ref: kubernetes-client/gen#93