Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling timeout by watch loop #39

Merged
merged 1 commit into from
Aug 15, 2018
Merged

fix: handling timeout by watch loop #39

merged 1 commit into from
Aug 15, 2018

Conversation

tomplus
Copy link
Owner

@tomplus tomplus commented Aug 15, 2018

resolve #29

Not closed connections filled up a connection pool and new connections couldn't be created.

@codecov-io
Copy link

codecov-io commented Aug 15, 2018

Codecov Report

Merging #39 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   93.51%   93.52%   +<.01%     
==========================================
  Files          16       16              
  Lines        1003     1004       +1     
==========================================
+ Hits          938      939       +1     
  Misses         65       65
Impacted Files Coverage Δ
kubernetes_asyncio/watch/watch.py 93.24% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e4e6f...fc160c5. Read the comment docs.

@tomplus tomplus merged commit be53058 into master Aug 15, 2018
@tomplus tomplus deleted the fix/close-con branch October 12, 2018 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problems with long-living watch
2 participants