Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config reader handles bool types #218

Merged
merged 1 commit into from
Aug 22, 2022
Merged

fix: config reader handles bool types #218

merged 1 commit into from
Aug 22, 2022

Conversation

tomplus
Copy link
Owner

@tomplus tomplus commented Aug 22, 2022

Fix #217

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #218 (9f507a5) into master (0680ea6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   26.98%   26.99%           
=======================================
  Files         728      728           
  Lines       97983    97988    +5     
=======================================
+ Hits        26444    26449    +5     
  Misses      71539    71539           
Impacted Files Coverage Δ
kubernetes_asyncio/config/kube_config.py 92.22% <100.00%> (ø)
kubernetes_asyncio/config/kube_config_test.py 94.53% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tomplus tomplus merged commit a9328c2 into master Aug 22, 2022
tomplus added a commit that referenced this pull request Aug 22, 2022
ChrisLovering added a commit to python-discord/king-arthur that referenced this pull request Aug 23, 2022
This fixes an issue where the config reader couldn't handle bool types.
See tomplus/kubernetes_asyncio#217 tomplus/kubernetes_asyncio#218
ChrisLovering added a commit to python-discord/king-arthur that referenced this pull request Aug 23, 2022
This fixes an issue where the config reader couldn't handle bool types.
See tomplus/kubernetes_asyncio#217 tomplus/kubernetes_asyncio#218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config reader does not support bool types
1 participant