fixed watch.stream bug of not working with apis with follow kwarg #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomplus
approved these changes
Aug 17, 2022
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 26.98% 26.98%
=======================================
Files 728 728
Lines 97983 97983
=======================================
Hits 26444 26444
Misses 71539 71539
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks for your contribution. I'm merging it now but later we can add an e2e test which uses the follow kwarg to prevent similar regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #215.
It still does not prevent the same issue from happening again. Not sure if there is a good way to prevent it.