Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional explicit config parameter to InClusterConfigLoader #196

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Added optional explicit config parameter to InClusterConfigLoader #196

merged 1 commit into from
Apr 4, 2022

Conversation

GlassOfWhiskey
Copy link
Contributor

This PR adds an optional client_configuration parameter to the InClusterConfigLoader, aligning its behavior with the one of KubeConfigLoader and allowing users to manage explicit Configuration objects also with this loading path.

Fixes #194

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #196 (e93a845) into master (aa44bfa) will increase coverage by 0.01%.
The diff coverage is 72.22%.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   27.42%   27.43%   +0.01%     
==========================================
  Files         702      702              
  Lines       93764    93776      +12     
==========================================
+ Hits        25712    25725      +13     
+ Misses      68052    68051       -1     
Impacted Files Coverage Δ
kubernetes_asyncio/config/incluster_config.py 87.75% <37.50%> (+2.64%) ⬆️
kubernetes_asyncio/config/incluster_config_test.py 97.61% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa44bfa...e93a845. Read the comment docs.

@tomplus
Copy link
Owner

tomplus commented Apr 4, 2022

@GlassOfWhiskey Good job, thanks for your contribution!

@tomplus tomplus merged commit d70b920 into tomplus:master Apr 4, 2022
@tomplus
Copy link
Owner

tomplus commented Apr 5, 2022

Released in v22.6.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make InClusterConfigLoader support explicit config parameter
2 participants