Increase aiohttp read buffer to 2MiB #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous default (64KiB) would cause `ValueError: Line is too long` exceptions on watch events with large objects. Requires aiohttp >= 3.7.0
|
This is one proposed way to handle #137. It requires aiohttp >=3.7.0, which is apparently incompatible with Python 3.5. |
tomplus
approved these changes
Feb 14, 2021
|
Python 3.5 is no longer supported. I'll clean tests/docs in next PR. (it fixes #137) |
tomplus
pushed a commit
that referenced
this pull request
Mar 25, 2021
The previous default (64KiB) would cause `ValueError: Line is too long` exceptions on watch events with large objects. Requires aiohttp >= 3.7.0
|
Can this be merged into a release please? |
|
Sorry, my mistake. I'll fix it soon. |
|
@rajasaur fixed in v22.6.2. Thanks for reporting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous default (64KiB) would cause
ValueError: Line is too longexceptions on watch events with large objects.
Requires aiohttp >= 3.7.0