fix: remove checking headers if raw content is returned from rest api #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomplus
commented
Oct 22, 2020
| @@ -188,17 +188,15 @@ async def __call_api( | |||
| e.body = e.body.decode('utf-8') if six.PY3 else e.body | |||
| raise e | |||
|
|
|||
| content_type = response_data.getheader('content-type') | |||
There was a problem hiding this comment.
response_data can be a raw response (aiohttp ClientResponse) if _preload_content is false. The raw response doesn't have methods like getheader, getheaders. This assign is not necessary here and can be done later when preloaded content is processing.
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 31.15% 31.15%
=======================================
Files 817 817
Lines 93176 93176
=======================================
Hits 29031 29031
Misses 64145 64145
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It solves #122
The workaround is implemented manually on generated code. PR for OpenApi generator is on the way.