Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling watch.stop() does not close the response correctly #60

Closed
hubo1016 opened this issue Feb 15, 2019 · 0 comments · Fixed by #61
Closed

Calling watch.stop() does not close the response correctly #60

hubo1016 opened this issue Feb 15, 2019 · 0 comments · Fixed by #61

Comments

@hubo1016
Copy link
Contributor

kubernetes_asyncio/kubernetes_asyncio/watch/watch.py

Lines 123 to 124 in d57e9e9

if self._stop:
raise StopAsyncIteration

It just raises an exception to exit.

I think we should add async context manager support for Watch objects, so it closes the response in __aexit__.
hubo1016 pushed a commit to hubo1016/kubernetes_asyncio that referenced this issue Feb 15, 2019
fix tomplus#60
e3f6012
@hubo1016 hubo1016 mentioned this issue Feb 15, 2019
Merged
tomplus pushed a commit that referenced this issue Feb 22, 2019
@hubo1016 @tomplus
watch improvement (context manager, close method) #60 (#61)
f83dc57 
It solves #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #60 hubo1016/kubernetes_asyncio
1 participant
@hubo1016