fix(analytics): allow custom event parameters for screen_view events

Fixes invertase#4594.
tomonacci · Oct 25, 2021 · bc42412 · bc42412
1 parent 89b104a
commit bc42412
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/packages/analytics/__tests__/analytics.test.ts b/packages/analytics/__tests__/analytics.test.ts
@@ -137,6 +137,9 @@ describe('Analytics', function () {
           'firebase.analytics().logScreenView(*):',
         );
       });
+      it('accepts custom event parameters', function () {
+        expect(() => firebase.analytics().logScreenView({ foo: 'bar' })).not.toThrow();
+      });
     });
 
     describe('logAddPaymentInfo()', function () {

diff --git a/packages/analytics/lib/index.d.ts b/packages/analytics/lib/index.d.ts
@@ -344,6 +344,10 @@ export namespace FirebaseAnalyticsTypes {
      * Current class associated with the view the user is currently viewing.
      */
     screen_class?: string;
+    /**
+     * Custom event parameters.
+     */
+    [key: string]: any;
   }
 
   export interface RefundEventParameters {

diff --git a/packages/analytics/lib/structs.js b/packages/analytics/lib/structs.js
@@ -32,7 +32,7 @@ const Item = struct({
   price: 'number?',
 });
 
-export const ScreenView = struct({
+export const ScreenView = struct.interface({
   screen_class: 'string?',
   screen_name: 'string?',
 });