allow insecure https connections #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomnomnom
reviewed
Feb 22, 2017
| @@ -12,4 +12,4 @@ fi | |||
|
|
|||
| # dupl is disabled because it has a habbit of identifying tests as duplicated code. | |||
| # in its defence: it's right. gocyclo is disabled because I'm a terrible programmer. | |||
| gometalinter --disable=gocyclo --disable=dupl --enable=mispell --enable=goimports | |||
|
All looks good to me! I've issued a PR against your master with a couple of tweaks to the linter config and an update to the help output in the readme file; it's not been updated for a while it seems - whoops! If you merge that PR I'll merge yours :) |
Tweaks linter settings; updates help output in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added -k and --insecure flags to support insecure https connections
/script/test runs ok
/script/lint produces an additional warning about InsecureSkipVerify being true
I had to change /script/lint include from mispell to misspell for it to execute ¯\_(ツ)_/¯