Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow heterogeneous arrays #676

Merged
merged 6 commits into from
Nov 6, 2019
Merged

Allow heterogeneous arrays #676

merged 6 commits into from
Nov 6, 2019

Conversation

ChristianSi
Copy link
Contributor

Fixes #665.

@pradyunsg
Copy link
Member

I like how the ANBF doesn't need to be updated for this. :P

@lmna
Copy link

lmna commented Nov 5, 2019 •
edited
Loading

The intent of nested_mixed_array example was to illustrate the limits of no-mixed-types restriction. Now when the restriction is gone, this example feels irrelevant.

@ChristianSi
Copy link
Contributor Author

@lmna While that is technically true, I feel it's not bad to have a variety of examples on how arrays might be used – this included.

@ChristianSi ChristianSi mentioned this pull request Nov 6, 2019
Closed
@pradyunsg
Copy link
Member

I don't think waiting for folks to chime in here would do much. Let's go ahead and do this. :)

@pradyunsg pradyunsg merged commit bcd7af2 into toml-lang:master Nov 6, 2019
@ChristianSi ChristianSi deleted the heterogeneous-arrays branch November 6, 2019 15:39
@mojombo
Copy link
Member

mojombo commented Nov 6, 2019

Looks good, thanks for the work on this, everyone.

@ehuss ehuss mentioned this pull request Nov 6, 2019
Closed
ToruNiina added a commit to ToruNiina/toml11 that referenced this pull request Nov 8, 2019
@ToruNiina
feat: allow heterogenous array
9af2d65 
if TOML11_USE_UNRELEASED_TOML_FEATURES is activated.
In TOML v0.5.0, heterogenous arrays are not allowed. But after some
discussions in toml-lang/toml, it is decided to allow it in the next
release (toml-lang/toml/pull/676).
To support it, disable type check in parse_array function.
@basile-henry basile-henry mentioned this pull request Nov 13, 2019
Open
@flokno flokno mentioned this pull request Dec 10, 2019
Open
@alinnert alinnert mentioned this pull request Apr 3, 2020
Open
1 task
@sdispater sdispater mentioned this pull request Apr 7, 2020
Merged
@oschwald oschwald mentioned this pull request Jan 28, 2021
Closed
@hadialqattan hadialqattan mentioned this pull request Jul 27, 2022
Closed
@eksortso eksortso mentioned this pull request Jun 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make arrays heterogeneous
4 participants
@ChristianSi @pradyunsg @lmna @mojombo