Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys should be identifier-like (addresses #65) #67

Closed
wants to merge 1 commit into from

Conversation

mrflip
Copy link

@mrflip mrflip commented Feb 24, 2013

Keys should contain only letters, numbers or underscore (_) characters, and should
start with a letter or underscore. See #65 for discussion.

Keys should contain only letters, numbers or underscore (`_`) characters, and should
start with a letter or underscore. See toml-lang#65 for discussion.
@manicolosi
Copy link
Contributor

In Lisps hyphens are more idiomatic than underscores. Maybe both should be supported. Or maybe a Lisp implementation should turn _ characters into - characters when parsing...

@kelvinst
Copy link

A good suggestion. Everything has a limit! 😃

@parkr
Copy link

parkr commented Aug 23, 2013

I would stick with just /[a-zA-Z0-9_]/ and omit hyphens. Then again, I primarily use Ruby, where hyphens signify the mathematical function of subtraction.

@kelvinst
Copy link

Nice @parkr, I agree...

@88Alex
Copy link

88Alex commented Aug 26, 2013

I'm in favour of letters, numbers, underscores, and hyphens.

@wycats wycats mentioned this pull request Jun 24, 2014
@BurntSushi
Copy link
Member

See #65 (comment)

@mojombo mojombo mentioned this pull request Jan 7, 2015
@mojombo
Copy link
Member

mojombo commented Jan 15, 2015

An alternative was merged in #283.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants