Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user-supplied resizerClassName prop additive #208

Conversation

dfsp-spirit
Copy link
Contributor

If a resizerClassName prop is supplied by the user, make it additive to the default class name (instead of completely replacing it).

… to the default class name (instead of completely replacing it).
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 90.686% when pulling b9815b1 on dfsp-spirit:make_resizerClassName_prop_additive_to_Resizer_defaultProps into 7c88eec on tomkp:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 90.686% when pulling fe42b66 on dfsp-spirit:make_resizerClassName_prop_additive_to_Resizer_defaultProps into 7c88eec on tomkp:master.

@dfsp-spirit
Copy link
Contributor Author

@tomkp This PR fixes that if you do something like

`<SplitPane split="horizontal" minSize={50} defaultSize={50} resizerClassName="my_custom_css_class">`

the resulting Resizer element does not have the "Resizer" class name anymore and thus all the CSS is not applied to it, effectively breaking it.

Without this PR, you have to do this to get it to work:

 `<SplitPane split="horizontal" minSize={50} defaultSize={50} resizerClassName="Resizer my_custom_css_class">`

I am not sure what your intended behavior is, but I would assume the resizerClassName prop to be additive.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 90.686% when pulling 7dbfc1e on dfsp-spirit:make_resizerClassName_prop_additive_to_Resizer_defaultProps into 7c88eec on tomkp:master.

@tomkp tomkp merged commit 16caf26 into tomkp:master Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants