Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments from tamasgal #57

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Comments from tamasgal #57

merged 2 commits into from
Oct 4, 2023

Conversation

tomkimpson
Copy link
Owner

This PR addresses JOSS reviewer comments

  1. Updates compat specs c.f. Version constraints on dependencies (compat entry) #56
  2. Adds contributing.md

@codecov-commenter
Copy link

Codecov Report

Merging #57 (139844d) into main (8adfb85) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff            @@
##              main       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         7    +1     
  Lines          332       337    +5     
=========================================
+ Hits           332       337    +5     

see 2 files with indirect coverage changes

@tamasgal
Copy link

tamasgal commented Oct 4, 2023

Looks good to me!

@tomkimpson tomkimpson merged commit 5473e4c into main Oct 4, 2023
5 checks passed
@tomkimpson tomkimpson deleted the tamasgal_comments branch October 4, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants