Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development guide #744

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Conversation

adamconnelly
Copy link
Contributor

I've added a new document with information about how to build and test Promitor, along with an overview of the repository layout.

Fixes #484

I've added a new document with information about how to build and test Promitor, along with an overview of the repository layout.

Fixes tomkerkhove#484
@adamconnelly
Copy link
Contributor Author

@tomkerkhove I'm not sure if this is quite what you're looking for, but I figured it's a starting point at least.

I've left a TODO about the deploy directory because I'm not quite sure what it's for, so if you can give me an outline of it I can update that.

Copy link
Owner

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks man!

development-guide.md Outdated Show resolved Hide resolved
development-guide.md Show resolved Hide resolved
development-guide.md Outdated Show resolved Hide resolved
@tomkerkhove
Copy link
Owner

One thing we could add is how to build the Docker image outside of VS.

  1. Navigate to /src
  2. Run docker build . --file .\Promitor.Scraper.Host\Dockerfile --tag promitor --no-cache should work

@adamconnelly
Copy link
Contributor Author

One thing we could add is how to build the Docker image outside of VS.

  1. Navigate to /src
  2. Run docker build . --file .\Promitor.Scraper.Host\Dockerfile --tag promitor --no-cache should work

Ok - I've added that.

What we might want to consider for future is making it easier to build and deploy the chart locally. For example, if we tag the image with same same tag referenced in the Helm chart, you can use your local image instead of having to pull it from the docker repo while doing local dev.

So we could create a values.local.yaml file that sets the tag to tomkerkhove/promitor-agent-scraper:local, and use that in the docker build command, then specify --values values.local.yaml when running the helm upgrade / install command. We do something pretty similar at work for running containers in a local cluster for development.

@tomkerkhove
Copy link
Owner

One thing we could add is how to build the Docker image outside of VS.

  1. Navigate to /src
  2. Run docker build . --file .\Promitor.Scraper.Host\Dockerfile --tag promitor --no-cache should work

Ok - I've added that.

What we might want to consider for future is making it easier to build and deploy the chart locally. For example, if we tag the image with same same tag referenced in the Helm chart, you can use your local image instead of having to pull it from the docker repo while doing local dev.

So we could create a values.local.yaml file that sets the tag to tomkerkhove/promitor-agent-scraper:local, and use that in the docker build command, then specify --values values.local.yaml when running the helm upgrade / install command. We do something pretty similar at work for running containers in a local cluster for development.

Would you mind opening an issue for this please? It's not fully clear to me what you are suggesting but don't want to block this PR on it!

@tomkerkhove tomkerkhove merged commit 9a92676 into tomkerkhove:master Oct 16, 2019
@tomkerkhove
Copy link
Owner

Thanks!

@adamconnelly
Copy link
Contributor Author

Would you mind opening an issue for this please? It's not fully clear to me what you are suggesting but don't want to block this PR on it!

No problem - it's really not a big deal, and it's not really related to this PR. It'll be easier for me to create an example to explain it.

@adamconnelly adamconnelly deleted the development-docs branch February 3, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide docs on how to build & test the codebase
2 participants