-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add development guide #744
Add development guide #744
Conversation
I've added a new document with information about how to build and test Promitor, along with an overview of the repository layout. Fixes tomkerkhove#484
@tomkerkhove I'm not sure if this is quite what you're looking for, but I figured it's a starting point at least. I've left a TODO about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks man!
One thing we could add is how to build the Docker image outside of VS.
|
Ok - I've added that. What we might want to consider for future is making it easier to build and deploy the chart locally. For example, if we tag the image with same same tag referenced in the Helm chart, you can use your local image instead of having to pull it from the docker repo while doing local dev. So we could create a values.local.yaml file that sets the tag to |
Would you mind opening an issue for this please? It's not fully clear to me what you are suggesting but don't want to block this PR on it! |
Thanks! |
No problem - it's really not a big deal, and it's not really related to this PR. It'll be easier for me to create an example to explain it. |
I've added a new document with information about how to build and test Promitor, along with an overview of the repository layout.
Fixes #484