Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide timestamps for logging #585

Merged
merged 1 commit into from
Jun 8, 2019
Merged

Conversation

tomkerkhove
Copy link
Owner

Fixes #571

New logs with timestamp

██████╗ ██████╗  ██████╗ ███╗   ███╗██╗████████╗ ██████╗ ██████╗
██╔══██╗██╔══██╗██╔═══██╗████╗ ████║██║╚══██╔══╝██╔═══██╗██╔══██╗
██████╔╝██████╔╝██║   ██║██╔████╔██║██║   ██║   ██║   ██║██████╔╝
██╔═══╝ ██╔══██╗██║   ██║██║╚██╔╝██║██║   ██║   ██║   ██║██╔══██╗
██║     ██║  ██║╚██████╔╝██║ ╚═╝ ██║██║   ██║   ╚██████╔╝██║  ██║
╚═╝     ╚═╝  ╚═╝ ╚═════╝ ╚═╝     ╚═╝╚═╝   ╚═╝    ╚═════╝ ╚═╝  ╚═╝
No scraping endpoint was specified, falling back to default '/metrics'...
No scraping configuration path was specified, falling back to default '/config/metrics-declaration.yaml'...
info: Validation[0]
      [2019-06-08 08:13:05Z] Starting validation of Promitor setup
info: Validation[0]
      [2019-06-08 08:13:05Z] Start Validation step 1/4: Metrics Declaration Path
warn: Validation[0]
      [2019-06-08 08:13:05Z] No scrape configuration path configured, falling back to default one on '/config/metrics-declaration.yaml'.
info: Validation[0]
      [2019-06-08 08:13:05Z] Scrape configuration found at '/config/metrics-declaration.yaml'
info: Validation[0]
      [2019-06-08 08:13:05Z] Validation step 1/4 succeeded
info: Validation[0]
      [2019-06-08 08:13:05Z] Start Validation step 2/4: Cron Schedule
warn: Validation[0]
      [2019-06-08 08:13:05Z] No scraping schedule was specified, falling back to default '*/5 * * * *' cron schedule...

Olds logs without stamp

██████╗ ██████╗  ██████╗ ███╗   ███╗██╗████████╗ ██████╗ ██████╗
██╔══██╗██╔══██╗██╔═══██╗████╗ ████║██║╚══██╔══╝██╔═══██╗██╔══██╗
██████╔╝██████╔╝██║   ██║██╔████╔██║██║   ██║   ██║   ██║██████╔╝
██╔═══╝ ██╔══██╗██║   ██║██║╚██╔╝██║██║   ██║   ██║   ██║██╔══██╗
██║     ██║  ██║╚██████╔╝██║ ╚═╝ ██║██║   ██║   ╚██████╔╝██║  ██║
╚═╝     ╚═╝  ╚═╝ ╚═════╝ ╚═╝     ╚═╝╚═╝   ╚═╝    ╚═════╝ ╚═╝  ╚═╝
No scraping configuration path was specified, falling back to default '/config/metrics-declaration.yaml'...
info: Validation[0]
      Starting validation of Promitor setup
info: Validation[0]
      Start Validation step 1/4: Metrics Declaration Path
warn: Validation[0]
      No scrape configuration path configured, falling back to default one on '/config/metrics-declaration.yaml'.
info: Validation[0]
      Scrape configuration found at '/config/metrics-declaration.yaml'
info: Validation[0]
      Validation step 1/4 succeeded

@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr585

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr585 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr585

You can find a CI version of our Helm chart on hub.helm.sh

@tomkerkhove tomkerkhove merged commit 9792d28 into master Jun 8, 2019
@tomkerkhove tomkerkhove deleted the features-timestamp-in-logs branch June 8, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide timestamps in logging
2 participants