Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency Prometheus.Client to v3 #523

Merged
merged 3 commits into from
Apr 27, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 27, 2019

This PR contains the following updates:

Package Type Update Change References
Prometheus.Client nuget major 2.2.2 -> 3.0.0 source

Release Notes

PrometheusClientNet/Prometheus.Client

v3.0.0

Compare Source

This major release dedicated mostly to reduce memory allocation especially while scrape collection to achieve this we made number of improvements and breaking changes.

Improvements:
  • Introduced IMetricsWriter, which used to produce metric samples without creation of CMetricFamily.
  • Added target to netcore2.2 which allow us to use non-allocating format methods. This dramatically reduces allocation while scrapping for application run on netcore2.2.
  • ICollectorRegistry and ICollector interfaces were reviewed.
  • Histogram and Summary now expose current state through Value property (which returns snapshot of the state).
  • Added CounterInt64 - counter optimized for integer values. It uses atomic operations instead of optimistic lock on value increment.
  • Added IValueObserver abstraction for Histogram and Summary, together with extension methods for convenient duration observation.
  • All value observation methods now support explicit setting timestamp for the observation.
  • Fluent syntax to register default collectors into the CollectorRegistry.
  • Reviewed MetricFactory to avoid unnecessary metric creation before checking CollectorRegistry for existing one.
  • Improved unit tests coverage and added benchmarks.
  • Library is Strong Named now.
Breaking changes:
  • Legacy .Net Framework 4.5 is not supported anymore.
  • Removed PerfCounter collectors as a platform dependent feature.
  • Removed all Contracts because of moving to IMetricsWriter.
  • TextFormatter was removed in favor of MetricsTextWriter.
  • CollectorRegistry.Instance was moved into Metrics.DefaultCollectorRegistry to isolate all static API into Metrics entry point.
  • Base classes Collector and Labelled have lots of changes to correspond new API and reduce allocation.
  • IOnDemandCollector was removed in favor of ICollector.
  • ScrapeHandler.Process methods is async now to follow .NET Core 3.0 synchronous operations restrictions.

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot requested a review from tomkerkhove as a code owner April 27, 2019 00:44
@renovate renovate bot added the dependencies All issues related to dependencies & Renovate label Apr 27, 2019
@renovate
Copy link
Contributor Author

renovate bot commented Apr 27, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr523

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr523 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr523

@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr523

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr523 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr523

@tomkerkhove tomkerkhove merged commit beebb4b into master Apr 27, 2019
@renovate renovate bot deleted the renovate-prometheus.client-3.x branch April 27, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies All issues related to dependencies & Renovate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants