Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cosmos DB scraper documentation & validation #500

Merged
merged 3 commits into from
Apr 8, 2019
Merged

Improve Cosmos DB scraper documentation & validation #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b703ffa
Fix documentation pointing to wrong metrics
tomkerkhove Apr 8, 2019
0d3900a
Improve validation message
tomkerkhove Apr 8, 2019
feaabc7
Align documentation file name
tomkerkhove Apr 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/configuration/metrics/cosmosdb.md → docs/configuration/metrics/cosmos-db.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ You can declare to scrape Cosmos Db via the `CosmosDb` resource type.
The following fields need to be provided:
- `dbName`- The name of the Cosmos Db to be scraped

All supported metrics are documented in the official [Azure Monitor documentation](https://docs.microsoft.com/en-us/azure/azure-monitor/platform/metrics-supported#microsoftcontainerinstancecontainergroups).
All supported metrics are documented in the official [Azure Monitor documentation](https://docs.microsoft.com/en-us/azure/azure-monitor/platform/metrics-supported#microsoftdocumentdbdatabaseaccounts).

Example:
```yaml
Expand Down
2 changes: 1 addition & 1 deletion docs/configuration/metrics/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ We also provide a simplified way to configure the following Azure resources:
- [Azure Virtual Machine](virtual-machine)
- [Azure Network Interface](network-interface)
- [Azure Storage Queue](storage-queue)
- [Cosmos DB](cosmosdb)
- [Cosmos DB](cosmos-db)

Want to help out? Create an issue and [contribute a new scraper](https://github.com/tomkerkhove/promitor/blob/master/adding-a-new-scraper.md).

Expand Down
2 changes: 1 addition & 1 deletion ...omitor.Scraper.Host/Validation/MetricDefinitions/ResourceTypes/CosmosDbMetricValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ protected override IEnumerable<string> Validate(CosmosDbMetricDefinition cosmosD

if (string.IsNullOrWhiteSpace(cosmosDbMetricDefinition.DbName))
{
yield return "No Cosmos db Name is configured";
yield return "No Cosmos DB name is configured";
}
}
}
Expand Down