Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no messages available with TimeSpentInQueue & Storage scraper #496

Merged
merged 1 commit into from
Apr 7, 2019

Conversation

tomkerkhove
Copy link
Owner

@tomkerkhove tomkerkhove commented Apr 7, 2019

Support no messages available with TimeSpentInQueue & Storage scraper by tracking 0 seconds if no messages are available.

Fixes #495

Samples

When one or more messages are queued:

# HELP demo_azurestoragequeue_queue_timespentinqueue Approximate amount of time that the oldest message has been in 'orders' queue (determined with StorageQueue provider)
# TYPE demo_azurestoragequeue_queue_timespentinqueue gauge
demo_azurestoragequeue_queue_timespentinqueue 15.212368 1554629347212

When no message is in queue:

# HELP demo_azurestoragequeue_queue_timespentinqueue Approximate amount of time that the oldest message has been in 'orders' queue (determined with StorageQueue provider)
# TYPE demo_azurestoragequeue_queue_timespentinqueue gauge
demo_azurestoragequeue_queue_timespentinqueue 0 1554629307416

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr496

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr496 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr496

@tomkerkhove tomkerkhove merged commit f0d83a8 into master Apr 7, 2019
@tomkerkhove tomkerkhove deleted the patch-TimeSpentInQueue-with-no-messages branch April 7, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants