Adding ability to define a custom AzureEnvironment. #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your contribution! 🙏 We will review it as soon as possible. |
tomkerkhove
requested changes
Nov 29, 2024
| @@ -81,6 +83,8 @@ public static Uri GetAzureAuthorityHost(this AzureCloud azureCloud) | |||
| return AzureAuthorityHosts.AzureGermany; | |||
| case AzureCloud.UsGov: | |||
| return AzureAuthorityHosts.AzureGovernment; | |||
| case AzureCloud.Custom: | |||
| return new Uri(Environment.GetEnvironmentVariable("PROMITOR_AZURE_AUTH_ENDPOINT")); | |||
There was a problem hiding this comment.
Let's not do this but move it to the YAML configuration instead please
Comment on lines
+21
to
+27
| Name = nameof(AzureCustomCloud), | ||
| AuthenticationEndpoint = Environment.GetEnvironmentVariable("PROMITOR_AUTH_ENDPOINT"), | ||
| ResourceManagerEndpoint = Environment.GetEnvironmentVariable("PROMITOR_RESOURCE_MANAGER_ENDPOINT"), | ||
| ManagementEndpoint = Environment.GetEnvironmentVariable("PROMITOR_MANAGEMENT_ENDPOINT"), | ||
| GraphEndpoint = Environment.GetEnvironmentVariable("PROMITOR_GRAPH_ENDPOINT"), | ||
| StorageEndpointSuffix = Environment.GetEnvironmentVariable("PROMITOR_STORAGE_ENDPOINT_SUFFIX"), | ||
| KeyVaultSuffix = Environment.GetEnvironmentVariable("PROMITOR_KEY_VAULT_SUFFIX") |
There was a problem hiding this comment.
Same here, let's move this to the YAML configuration instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a custom azure environment whose endpoints can be defined via environment variables in a helm values file. This creates the ability to deploy to new regions without requiring code changes.