Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide support for Azure Firewall #2545

Merged
merged 12 commits into from
Sep 24, 2024

Conversation

locmai
Copy link
Contributor

@locmai locmai commented Sep 18, 2024

When implementing a new scraper; these tasks are completed:

Metrics output:

azure_firewall_application_rule_hits{tenant_id="<redacted>",subscription_id="<redacted>",status="unknown",resource_uri="subscriptions/<redacted>/resourceGroups/<redacted>-vnet/providers/Microsoft.Network/azureFirewalls/<redacted>-firewall",resource_group="<redacted>-vnet",instance_name="<redacted>-firewall"} NaN 1726675946568
azure_firewall_application_rule_hits{tenant_id="<redacted>",subscription_id="<redacted>b",status="Allow",resource_uri="subscriptions/<redacted>/resourceGroups/<redacted>-vnet/providers/Microsoft.Network/azureFirewalls/<redacted>-firewall",resource_group="<redacted>-vnet",instance_name="<redacted>-firewall"} 84 1726675946630
azure_firewall_application_rule_hits{tenant_id="<redacted>",subscription_id="<redacted>",status="Deny",resource_uri="subscriptions/<redacted>/resourceGroups/<redacted>-vnet/providers/Microsoft.Network/azureFirewalls/<redacted>-firewall",resource_group="<redacted>vnet",instance_name="<redacted>-firewall"} 204 1726675946627

Discovery output:

/api/v1/health

{"entries":{"azure-resource-graph":{"data":{"Subscription <redacted>":{"isSuccessful":true,"message":"Successfully queried resources via Azure Resource Graph"}},"description":"Successfully queried all subscriptions","duration":"00:00:00.1368361","status":"Healthy","tags":[]}},"status":"Healthy","totalDuration":"00:00:00.1413060"}

/api/v2/resources/groups/azure-firewall-landscape/discover

{"$type":"Promitor.Core.Contracts.PagedPayload`1[[Promitor.Core.Contracts.AzureResourceDefinition, Promitor.Core.Contracts]], Promitor.Core.Contracts","Result":[{"$type":"Promitor.Core.Contracts.ResourceTypes.AzureFirewallResourceDefinition, Promitor.Core.Contracts","AzureFirewallName":"<redacted>-vnet-firewall","ResourceType":"AzureFirewall","SubscriptionId":"<redacted>","ResourceGroupName":"<redacted>","ResourceName":"<redacted>-vnet-firewall","UniqueName":"<redacted>-vnet-firewall"},{"$type":"Promitor.Core.Contracts.ResourceTypes.AzureFirewallResourceDefinition, Promitor.Core.Contracts","AzureFirewallName":"<redacted>-firewall","ResourceType":"AzureFirewall","SubscriptionId":"<redacted>","ResourceGroupName":"<redacted>-validation","ResourceName":"<redacted>-validation-firewall","UniqueName":"<redacted>-validation-firewall"},{"$type":"Promitor.Core.Contracts.ResourceTypes.AzureFirewallResourceDefinition, Promitor.Core.Contracts","AzureFirewallName":"<redacted>-firewall","ResourceType":"AzureFirewall","SubscriptionId":"<redacted>","ResourceGroupName":"<redacted>-vnet","ResourceName":"<redacted>-firewall","UniqueName":"<redacted>-firewall"},{"$type":"Promitor.Core.Contracts.ResourceTypes.AzureFirewallResourceDefinition, Promitor.Core.Contracts","AzureFirewallName":"<redacted>-firewall","ResourceType":"AzureFirewall","SubscriptionId":"<redacted>","ResourceGroupName":"<redacted>-vnet","ResourceName":"<redacted>-firewall","UniqueName":"<redacted>-firewall"},{"$type":"Promitor.Core.Contracts.ResourceTypes.AzureFirewallResourceDefinition, Promitor.Core.Contracts","AzureFirewallName":"<redacted>-firewall","ResourceType":"AzureFirewall","SubscriptionId":"<redacted>","ResourceGroupName":"<redacted>-vnet","ResourceName":"<redacted>-firewall","UniqueName":"<redacted>-vnet-firewall"}],"PageInformation":{"$type":"Promitor.Core.Contracts.PageInformation, Promitor.Core.Contracts","PageSize":1000,"CurrentPage":1,"TotalRecords":5},"HasMore":false}

@locmai locmai requested a review from tomkerkhove as a code owner September 18, 2024 09:27
Copy link

Thank you for your contribution! 🙏 We will review it as soon as possible.

@locmai locmai force-pushed the feat/azure-firewall branch from 5f6e6ae to 8364409 Compare September 18, 2024 17:09
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Copy link
Owner

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

@tomkerkhove
Copy link
Owner

/azp run "Promitor CI - Resource Discovery Agent"

@tomkerkhove
Copy link
Owner

/azp run "Promitor CI - Scraper Agent"

Copy link

No pipelines are associated with this pull request.

1 similar comment
Copy link

No pipelines are associated with this pull request.

@tomkerkhove tomkerkhove merged commit 880d10e into tomkerkhove:master Sep 24, 2024
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants