-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provide support for Azure Firewall #2545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! 🙏 We will review it as soon as possible. |
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
locmai
force-pushed
the
feat/azure-firewall
branch
from
September 18, 2024 17:09
5f6e6ae
to
8364409
Compare
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
tomkerkhove
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton!
/azp run "Promitor CI - Resource Discovery Agent" |
/azp run "Promitor CI - Scraper Agent" |
No pipelines are associated with this pull request. |
1 similar comment
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing a new scraper; these tasks are completed:
Metrics output:
Discovery output:
/api/v1/health
/api/v2/resources/groups/azure-firewall-landscape/discover