Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to .net core 7.0.16 #2442

Closed
wants to merge 3 commits into from
Closed

chore: upgrade to .net core 7.0.16 #2442

wants to merge 3 commits into from

Conversation

hkfgo
Copy link
Collaborator

@hkfgo hkfgo commented Feb 14, 2024

Fixes #

@hkfgo hkfgo requested a review from tomkerkhove as a code owner February 14, 2024 00:40
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review it as soon as possible.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Feb 14, 2024
@hkfgo hkfgo changed the title upgrade to .net core 7.0.16 chore: upgrade to .net core 7.0.16 Feb 14, 2024
tomkerkhove
tomkerkhove reviewed Feb 14, 2024
View reviewed changes
src/output.txt Outdated
@@ -0,0 +1,283 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete this file?

tomkerkhove
tomkerkhove requested changes Feb 14, 2024
View reviewed changes
Copy link
Owner

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update build/azure-devops/variables/build.yml please?

@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Feb 14, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Feb 16, 2024
tomkerkhove
tomkerkhove reviewed Feb 16, 2024
View reviewed changes
src/Promitor.Agents.ResourceDiscovery/Dockerfile.windows
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/dotnet/sdk:7.0.402 AS build
FROM mcr.microsoft.com/dotnet/sdk:7.0.406 AS build
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the Linux image as well please?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to commit it sorry :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries!

@tomkerkhove
Copy link
Owner

/azp run Promitor CI - Scraper Agent

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hkfgo
Copy link
Collaborator Author

hkfgo commented Feb 24, 2024

Do you mind re-running that pipeline again? Unless I can do it too even as a non-maintainer? Integration tests seem to be just hanging without any obvious failures.

@hkfgo
Copy link
Collaborator Author

hkfgo commented Feb 24, 2024

On a separate note, do you think this PR to bump AzureIdentity looks good? We are hoping for release that includes both PRs to address CVEs.

@tomkerkhove
Copy link
Owner

It looks like the CI is timing out everywhere for some reason so I'm checking that.

In meantime, I'll likely upgrade to .NET 8 given that is GA now: #2402

@hkfgo
Copy link
Collaborator Author

hkfgo commented Feb 26, 2024 •
edited
Loading

It looks like the CI is timing out everywhere for some reason so I'm checking that.

Thanks.

In meantime, I'll likely upgrade to .NET 8 given that is GA now: #2402

I was going to take that on actually. Do you mind if I go ahead with that? Just for my own learning mostly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove requested changes

Assignees
No one assigned
Labels
🔍 Ready for Review Pull Request is not reviewed yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hkfgo @tomkerkhove