feat: Add Opentelemetry Export protocol option #2318
Conversation
Changed: AddOpenTelemetryCollectorMetricSink now takes all Otel Options Added: options.Protocol to OpenTelemetry exporter. Defaults to Grpc if http not found in config. Grpc is already default.
bunkrur
changed the title
There was a problem hiding this comment.
Thanks for the PR! Added some comments. Would you mind also updating the docs please? https://github.com/promitor/docs
...or.Integrations.Sinks.OpenTelemetry/Configuration/OpenTelemetryCollectorSinkConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Promitor.Agents.Scraper/Extensions/IServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
Changed: To equals from Startswith. Lets be explicit. Added: Validation for protocol, even if using default Added: Forcing grpc (which is already default) within CollectorInfo properties. Added: Nested CollectorInfo class
src/Promitor.Agents.Scraper/Extensions/IServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
|
|
||
| public class CollectorInfo | ||
| { | ||
| public string CollectorProtocol { get; set; } = "grpc"; |
There was a problem hiding this comment.
Let's introduce Uri here as well to be consistent and deprecate the old one
There was a problem hiding this comment.
Added to new class but kept filename :)
There was a problem hiding this comment.
see other comment about class after I nuked the unit tests. Also, a change to the class structure or a nested class would maybe need runtime.yaml changes, which I think we should avoid?
...or.Integrations.Sinks.OpenTelemetry/Configuration/OpenTelemetryCollectorSinkConfiguration.cs
Outdated
Show resolved
Hide resolved
...or.Integrations.Sinks.OpenTelemetry/Configuration/OpenTelemetryCollectorSinkConfiguration.cs
Outdated
Show resolved
Hide resolved
...itor.Agents.Scraper/Validation/Steps/Sinks/OpenTelemetryCollectorMetricSinkValidationStep.cs
Outdated
Show resolved
Hide resolved
...itor.Agents.Scraper/Validation/Steps/Sinks/OpenTelemetryCollectorMetricSinkValidationStep.cs
Show resolved
Hide resolved
|
Sameer Nafdey seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Closing, will reopen. |
Relates to #2316