Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(otel): Provide correct job name in OpenTelemetry Collector #2235

Merged
merged 3 commits into from
Feb 25, 2023
Merged

fix(otel): Provide correct job name in OpenTelemetry Collector #2235

merged 3 commits into from
Feb 25, 2023

Conversation

tomkerkhove
Copy link
Owner 

# HELP otel_azure_container_instance_cpu_usage_discovered Average cpu usage of our container instance
# TYPE otel_azure_container_instance_cpu_usage_discovered gauge
- otel_azure_container_instance_cpu_usage_discovered{app="promitor",instance="15cdf614-d987-4fbb-b6f5-1df5cc071ac9",instance_name="promitor-testing-resource-eu-aci",job="unknown_service:dotnet",resource_group="promitor-testing-infrastructure-europe",resource_uri="subscriptions/63c590b6-4947-4898-92a3-cae91a31b5e4/resourceGroups/promitor-testing-infrastructure-europe/providers/Microsoft.ContainerInstance/containerGroups/promitor-testing-resource-eu-aci",subscription_id="63c590b6-4947-4898-92a3-cae91a31b5e4"} 0 1677336928582
+ otel_azure_container_instance_cpu_usage_discovered{app="promitor",instance="15cdf614-d987-4fbb-b6f5-1df5cc071ac9",instance_name="promitor-testing-resource-eu-aci",job="promitor-scraper",resource_group="promitor-testing-infrastructure-europe",resource_uri="subscriptions/63c590b6-4947-4898-92a3-cae91a31b5e4/resourceGroups/promitor-testing-infrastructure-europe/providers/Microsoft.ContainerInstance/containerGroups/promitor-testing-resource-eu-aci",subscription_id="63c590b6-4947-4898-92a3-cae91a31b5e4"} 0 1677336928582

Closes #2179

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Feb 25, 2023
@tomkerkhove tomkerkhove merged commit 7e7a66f into master Feb 25, 2023
@tomkerkhove tomkerkhove deleted the otel-job-name branch February 25, 2023 16:18
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Feb 25, 2023
@hkfgo hkfgo mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenTelemetry job name is wrong name
1 participant
@tomkerkhove