Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Generic scraper doc #1941

Merged
merged 6 commits into from
Jan 27, 2022

Conversation

AntoineThebaud
Copy link
Contributor

@AntoineThebaud AntoineThebaud commented Jan 26, 2022

  • Highlight the fact that the filter parameter is optional.
  • Inform people about the filter syntax.
  • Inform people about the other optional fields available.

Fixes #1740
Fixes #1849.

- Highlight the fact that the filter parameter is optional.
- Inform people about the filter syntax (tomkerkhove#1740).
- Inform people about the other optional fields available (tomkerkhove#1849).
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jan 26, 2022
@AntoineThebaud AntoineThebaud changed the title Update Generic scraper doc docs: Update Generic scraper doc Jan 26, 2022
Copy link
Owner

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some tweaks

docs/configuration/v2.x/metrics/generic-azure-resource.md Outdated Show resolved Hide resolved
docs/configuration/v2.x/metrics/generic-azure-resource.md Outdated Show resolved Hide resolved
docs/configuration/v2.x/metrics/generic-azure-resource.md Outdated Show resolved Hide resolved
Copy link
Owner

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton! Don't forget to participate in the hackathon if you want (requires to fill in a form)

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet ✅ Approved Pull Request has been approved and can be merged labels Jan 27, 2022
@tomkerkhove tomkerkhove merged commit 241121f into tomkerkhove:master Jan 27, 2022
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
2 participants