Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate to .NET 6.0 #1833

Merged
merged 17 commits into from
Nov 22, 2021
Merged

chore: Migrate to .NET 6.0 #1833

merged 17 commits into from
Nov 22, 2021

Conversation

tomkerkhove
Copy link
Owner

@tomkerkhove tomkerkhove commented Nov 20, 2021

Migrate to .NET 6.0

  • Migrate to .NET 6.0
  • Run & post performance test comparison
  • Update changelog
    • Difference in Docker image size
    • Improvements such as startup trace

Closes #1339

Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Nov 20, 2021
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
@tomkerkhove
Copy link
Owner Author

As part of the migration, I ran a few performance benchmarks.

Scraping metrics on Scraper agent

In this scenario, we automatically send a growing number of requests (5 to 25) to scrape metrics over 60 seconds.

image

Source

Measurements

Runtime Test Run Total Requests Total Failures Latency - Min Latency - Max Latency - Median Latency - P95 Latency - P99 Requests/second
.NET 3.1 Test Run #1 680 100 (14.7%) 1610 ms 9941 ms 4231.1 ms 9416.8 ms 9801.2 ms 10/sec
Test Run #2 749 0 4 ms 7656 ms 1380.5 ms 7117 ms 7407.5 ms 13/sec
Test Run #3 707 0 4 ms 6165 ms 1525.7 ms 4492.8 ms 5711.5 ms 14/sec
.NET 6.0 Test Run #1 709 0 (0%) 3 ms 2790 ms 82.3 ms 2465.6 ms 2671 ms 12/sec
Test Run #2 710 1 (0.14%) 3 ms 3833 ms 16 ms 2186.8 ms 3072.4 ms 13/sec
Test Run #3 738 2 (0.27%) 3 ms 4765 ms 22 ms 3328.3 ms 3678.4 ms 14/sec

Probing health endpoint on Resource Discovery agent

In this scenario, we automatically send a growing number of requests (5 to 25) to probe the health endpoint over 60 seconds.

image

Source

Measurements

Runtime Total Requests Total Failures Latency - Min Latency - Max Latency - Median Latency - P95 Latency - P99 Requests/second
.NET 3.1 567 550 (97%) 1035 ms 8599 ms 1326.4 ms 8352 ms 8352 ms 8/sec
.NET 6.0 723 527 (72,9%) 431 ms 9843 ms 1274.3 ms 3328.3 ms 5711.5 ms 14/sec

@tomkerkhove tomkerkhove merged commit 75ce0ca into master Nov 22, 2021
@tomkerkhove tomkerkhove deleted the dotnet-6.0 branch November 22, 2021 07:05
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to .NET 6.0
1 participant