Provide scraper for Azure Kubernetes Service #1322

jkataja · 2020-10-19T14:42:53Z

Implement support for Azure Kubernetes Service (AKS) resource

Fixes #333

CLAassistant · 2020-10-19T14:43:04Z

All committers have signed the CLA.

promitor-bot · 2020-10-19T14:47:57Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1322-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

You can find a CI version of our Helm chart on hub.helm.sh

tomkerkhove

LGTM, but would like to rename the resource type to KubernetesService

Also, can you update our changelog in https://github.com/tomkerkhove/promitor/blob/master/changelog/content/experimental/unreleased.md please?

docs/configuration/v2.x/metrics/kuberbetes.md

docs/configuration/v2.x/metrics/index.md

src/Promitor.Core.Contracts/ResourceType.cs

Co-authored-by: Tom Kerkhove <[email protected]>

promitor-bot · 2020-10-20T08:58:30Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1322-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2020-10-20T08:58:36Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1322-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2020-10-20T09:14:04Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1322-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2020-10-20T09:19:14Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1322-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

You can find a CI version of our Helm chart on hub.helm.sh

JanneKataja-TomTom · 2020-10-20T09:29:37Z

Should I flatten it back into a single commit again?

promitor-bot · 2020-10-20T09:30:13Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1322-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2020-10-20T09:38:47Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1322-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

You can find a CI version of our Helm chart on hub.helm.sh

tomkerkhove

LGTM, thanks!

Would you mind fixing the code listing issues from the CI?

Then we are good to go once the CLA is ok.

promitor-bot · 2020-10-20T12:26:46Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1322-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2020-10-20T12:36:08Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1322-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1322-linux

You can find a CI version of our Helm chart on hub.helm.sh

tomkerkhove · 2020-10-20T12:44:48Z

Should I flatten it back into a single commit again?

No worries, I'll squash the PR anyway!

JanneKataja-TomTom · 2020-10-20T12:52:28Z

I fixed the code inspections, just waiting for the CLA to come through! 👍

JanneKataja-TomTom · 2020-10-23T14:04:53Z

The CLA came thru and I have signed it. Have a nice weekend!

tomkerkhove · 2020-10-23T14:06:14Z

Thanks a ton @jkataja !

JanneKataja-TomTom added 2 commits October 19, 2020 16:25

Support Azure Kubernetes Service (AKS) (tomkerkhove#333)

66072d7

Improve error msg when ResourceType is not matched

963bcb7

jkataja requested a review from tomkerkhove as a code owner October 19, 2020 14:42

trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Oct 19, 2020

tomkerkhove changed the title ~~Kubernetes resource~~ Provide scraper for Azure Kubernetes Service Oct 19, 2020

tomkerkhove requested changes Oct 20, 2020

View reviewed changes

trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Oct 20, 2020

Update docs/configuration/v2.x/metrics/kuberbetes.md

973d14b

Co-authored-by: Tom Kerkhove <[email protected]>

trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Oct 20, 2020

JanneKataja-TomTom added 2 commits October 20, 2020 11:08

Rename 'Kubernetes' to 'KubernetesService'

87f02b3

Change 'Kuberntes' to 'KubernetesService' in docs

ef1106f

JanneKataja-TomTom added 2 commits October 20, 2020 11:19

Add link to Kubernetes Service metrics in page

4d45384

Add Kubernetes Service to changelog

45e55e9

Fix typo in file name

e441596

tomkerkhove approved these changes Oct 20, 2020

View reviewed changes

trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Oct 20, 2020

Fix warning for argument type string in exception

984a137

trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Oct 20, 2020

trafico-bot bot removed the ✅ Approved Pull Request has been approved and can be merged label Oct 20, 2020

Fix varable naming for code quality check

56858fc

tomkerkhove merged commit c6aab27 into tomkerkhove:master Oct 23, 2020

trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Oct 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide scraper for Azure Kubernetes Service #1322

Provide scraper for Azure Kubernetes Service #1322

jkataja commented Oct 19, 2020

CLAassistant commented Oct 19, 2020 •

edited

Loading

promitor-bot commented Oct 19, 2020

tomkerkhove left a comment

promitor-bot commented Oct 20, 2020

promitor-bot commented Oct 20, 2020

promitor-bot commented Oct 20, 2020

promitor-bot commented Oct 20, 2020

JanneKataja-TomTom commented Oct 20, 2020

promitor-bot commented Oct 20, 2020

promitor-bot commented Oct 20, 2020

tomkerkhove left a comment

promitor-bot commented Oct 20, 2020

promitor-bot commented Oct 20, 2020

tomkerkhove commented Oct 20, 2020

JanneKataja-TomTom commented Oct 20, 2020

JanneKataja-TomTom commented Oct 23, 2020

tomkerkhove commented Oct 23, 2020

Provide scraper for Azure Kubernetes Service #1322

Provide scraper for Azure Kubernetes Service #1322

Conversation

jkataja commented Oct 19, 2020

CLAassistant commented Oct 19, 2020 • edited Loading

promitor-bot commented Oct 19, 2020

tomkerkhove left a comment

Choose a reason for hiding this comment

promitor-bot commented Oct 20, 2020

promitor-bot commented Oct 20, 2020

promitor-bot commented Oct 20, 2020

promitor-bot commented Oct 20, 2020

JanneKataja-TomTom commented Oct 20, 2020

promitor-bot commented Oct 20, 2020

promitor-bot commented Oct 20, 2020

tomkerkhove left a comment

Choose a reason for hiding this comment

promitor-bot commented Oct 20, 2020

promitor-bot commented Oct 20, 2020

tomkerkhove commented Oct 20, 2020

JanneKataja-TomTom commented Oct 20, 2020

JanneKataja-TomTom commented Oct 23, 2020

tomkerkhove commented Oct 23, 2020

CLAassistant commented Oct 19, 2020 •

edited

Loading