more style fixes :(

src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatchProperties.cs

@@ -95,7 +95,7 @@ public string BuildBatchHashKey()
         /// </summary>
         public bool Equals(ScrapeDefinitionBatchProperties obj)
         {
-            if (obj is null || !(obj is ScrapeDefinitionBatchProperties))
+            if (!(obj is ScrapeDefinitionBatchProperties))
                 return false;
 
             ScrapeDefinitionBatchProperties other = obj;

src/Promitor.Core.Scraping/Configuration/Serialization/v1/Model/MetricsDeclarationV1.cs

@@ -1,5 +1,4 @@
 using System.Collections.Generic;
-using Promitor.Core.Scraping.Configuration.Model;
 using Promitor.Core.Serialization.Enum;
 
 namespace Promitor.Core.Scraping.Configuration.Serialization.v1.Model

src/Promitor.Core.Scraping/LogAnalyticsScraper.cs

@@ -1,10 +1,8 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Net;
 using System.Threading.Tasks;
 using GuardNet;
-using Microsoft.VisualBasic;
 using Promitor.Core.Contracts;
 using Promitor.Core.Contracts.ResourceTypes;
 using Promitor.Core.Metrics;
@@ -55,7 +53,6 @@ private Dictionary<string, string> DetermineMetricLabels(LogAnalyticsResourceDef
 
         protected override async Task<List<ScrapeResult>> BatchScrapeResourceAsync(string subscriptionId, BatchScrapeDefinition<IAzureResourceDefinition> batchScrapeDefinition, PromitorMetricAggregationType aggregationType, TimeSpan aggregationInterval)
         {
-            // TODO: these just dispatch and await on tasks that do single-resource scraping. Implement integration with Log Analytics batch endpoint  
             var logScrapingTasks = batchScrapeDefinition.ScrapeDefinitions.Select(definition => ScrapeResourceAsync(subscriptionId, definition, (LogAnalyticsResourceDefinition) definition.Resource, aggregationType, aggregationInterval)).ToList();
 
             var resultsList = await Task.WhenAll(logScrapingTasks);

src/Promitor.Core/Extensions/MeasureMetricExtensions.cs

@@ -4,6 +4,7 @@ namespace Promitor.Core.Extensions
 {
     public static class MeasuredMetricExtensions
     {
+        /// <param name="measuredMetric">A time series value</param>
         /// <param name="resourceId">Resource ID to associate the metric with</param>
         /// <returns>Instance of MeasuredMetric subclass with resourceId attached</returns>
         public static ResourceAssociatedMeasuredMetric WithResourceIdAssociation(this MeasuredMetric measuredMetric, string resourceId)

src/Promitor.Integrations.AzureMonitor/AzureMonitorQueryClient.cs

@@ -23,7 +23,6 @@
 using Azure.Core.Diagnostics;
 using System.Diagnostics.Tracing;
 using Promitor.Integrations.AzureMonitor.Extensions;
-using System.Globalization;
 
 namespace Promitor.Integrations.AzureMonitor
 {
@@ -302,7 +301,7 @@ private MetricsClient CreateAzureMonitorMetricsBatchClient(AzureCloud azureCloud
         public static string InsertRegionIntoUrl(string region, string baseUrl)
         {
             // Find the position where ".metrics" starts in the URL
-            int metricsIndex = baseUrl.IndexOf("metrics", System.StringComparison.Ordinal);
+            int metricsIndex = baseUrl.IndexOf("metrics", StringComparison.Ordinal);
 
             // Split the base URL into two parts: before and after the ".metrics"
             string beforeMetrics = baseUrl.Substring(0, metricsIndex);

src/Promitor.Integrations.AzureMonitor/Configuration/AzureMonitorMetricBatchScrapeConfig.cs

@@ -1,11 +1,9 @@
-using Azure.Core;
-
 namespace Promitor.Integrations.AzureMonitor.Configuration
 {
     public class AzureMonitorMetricBatchScrapeConfig
     {
         public bool Enabled { get; set; } = false;
         public int MaxBatchSize { get; set; }
-        public string AzureRegion { get; set; } = "eastus"; // Batch scrape endpoints are deployed by region 
+        public string AzureRegion { get; set; } // Batch scrape endpoints are deployed by region 
     }
 }

src/Promitor.Integrations.AzureMonitor/HttpPipelinePolicies/ModifyOutgoingAzureMonitorRequestsPolicy.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Globalization;
-using System.Text;
 using System.Threading.Tasks;
 using Azure.Core;
 using Azure.Core.Pipeline;

src/Promitor.Tests.Unit/Core/Metrics/ScrapeDefinitionBatchPropertiesTest.cs

@@ -169,15 +169,15 @@ public void BuildBatchHashKeyDifferentResultDifferentSchedule()
         [Fact]
         public void BuildBatchHashKeyTest()
         {
-            AzureMetricConfigurationV1 _azureMetricConfigurationTest1 = new AzureMetricConfigurationV1 
+            AzureMetricConfigurationV1 azureMetricConfigurationTest1 = new AzureMetricConfigurationV1 
             {
                 MetricName = "availabilityResults/availabilityPercentage",
                 Aggregation = new MetricAggregationV1
                 {
                     Type = PromitorMetricAggregationType.Average
                 },
             };
-            AzureMetricConfigurationV1 _azureMetricConfigurationTest2 = new AzureMetricConfigurationV1 
+            AzureMetricConfigurationV1 azureMetricConfigurationTest2 = new AzureMetricConfigurationV1 
             {
                 MetricName = "availabilityResults/availabilityPercentage",
                 Dimensions = [new MetricDimensionV1{Name = "availabilityResult/name"}],
@@ -186,8 +186,8 @@ public void BuildBatchHashKeyTest()
                     Type = PromitorMetricAggregationType.Average
                 },
             };
-            var azureMetricConfiguration1 = _mapper.Map<AzureMetricConfiguration>(_azureMetricConfigurationTest1);
-            var azureMetricConfiguration2 = _mapper.Map<AzureMetricConfiguration>(_azureMetricConfigurationTest2);
+            var azureMetricConfiguration1 = _mapper.Map<AzureMetricConfiguration>(azureMetricConfigurationTest1);
+            var azureMetricConfiguration2 = _mapper.Map<AzureMetricConfiguration>(azureMetricConfigurationTest2);
 
             var scraping1 = _mapper.Map<Promitor.Core.Scraping.Configuration.Model.Scraping>(scrapingBase);
             var scraping2 = _mapper.Map<Promitor.Core.Scraping.Configuration.Model.Scraping>(scrapingBase);

src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.ComponentModel;
-using System.Threading;
 using AutoMapper;
 using Promitor.Core.Contracts;
 using Promitor.Core.Metrics;
@@ -12,7 +11,7 @@
 using Promitor.Core.Scraping.Configuration.Serialization.v1.Model;
 using Xunit;
 
-namespace Promitor.Tests.Unit.Core.Metrics
+namespace Promitor.Tests.Unit.Core.Scraping.Batching
 {
     [Category("Unit")]
     public class AzureResourceDefinitionBatchingTests