get rid of some redundant code

tomkerkhove · Sep 26, 2024 · b2d3458 · b2d3458
1 parent 299ec6e
commit b2d3458
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatchProperties.cs b/src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatchProperties.cs
@@ -93,12 +93,8 @@ public string BuildBatchHashKey()
         /// <summary>
         /// Equality comparison override in case of hash collision
         /// </summary>
-        public bool Equals(ScrapeDefinitionBatchProperties obj)
+        public bool Equals(ScrapeDefinitionBatchProperties other)
         {
-            if (!(obj is ScrapeDefinitionBatchProperties))
-                return false;
-
-            ScrapeDefinitionBatchProperties other = obj;
             return ResourceType == other.ResourceType && AzureMetricConfiguration.ToUniqueStringRepresentation() == other.AzureMetricConfiguration.ToUniqueStringRepresentation() && SubscriptionId == other.SubscriptionId && GetAggregationInterval().Equals(other.GetAggregationInterval());
         }
     }