Address comments

src/Promitor.Agents.Scraper/Scheduling/ResourcesScrapingJob.cs

@@ -266,7 +266,7 @@ private async Task ScrapeMetrics(IEnumerable<ScrapeDefinition<IAzureResourceDefi
                     Logger.LogInformation("Logging individual definitions batch: Azure Metric {AzureMetricName} and resource type {ResourceType}.", azureMetricName, resourceType);
                     foreach (ScrapeDefinition<IAzureResourceDefinition> definition in batchScrapeDefinition.ScrapeDefinitions)
                     {
-                        Logger.LogInformation("ResourceID: {ResoureceID}, ResourceGroup: {ResourceGroup}, Prometheus metric name: {MetricName}, Batch Key: {BatchKey}", definition.Resource.ResourceName, definition.ResourceGroupName, definition.PrometheusMetricDefinition.Name, definition.BuildPropertiesForBatch().BuildBatchHashKey());
+                        Logger.LogInformation("ResourceID: {ResoureceID}, ResourceGroup: {ResourceGroup}, Prometheus metric name: {MetricName}, Batch Key: {BatchKey}", definition.Resource.ResourceName, definition.ResourceGroupName, definition.PrometheusMetricDefinition.Name, definition.BuildScrapingBatchInfo().BuildBatchHashKey());
                     }
                     await ScheduleLimitedConcurrencyAsyncTask(tasks, () => ScrapeMetricBatched(batchScrapeDefinition), cancellationToken);
                 }

src/Promitor.Core.Scraping/Batching/AzureResourceDefinitionBatching.cs

@@ -17,7 +17,7 @@ public static class AzureResourceDefinitionBatching
         /// </summary>
         public static List<BatchScrapeDefinition<IAzureResourceDefinition>> GroupScrapeDefinitions(IEnumerable<ScrapeDefinition<IAzureResourceDefinition>> allScrapeDefinitions, int maxBatchSize, CancellationToken cancellationToken) 
         {
-            return  allScrapeDefinitions.GroupBy(def => def.BuildPropertiesForBatch()) 
+            return  allScrapeDefinitions.GroupBy(def => def.BuildScrapingBatchInfo()) 
                         .ToDictionary(group => group.Key, group => group.ToList()) // first pass to build batches that could exceed max 
                         .ToDictionary(group => group.Key, group => SplitScrapeDefinitionBatch(group.Value, maxBatchSize, cancellationToken)) // split to right-sized batches 
                         .SelectMany(group => group.Value.Select(batch => new BatchScrapeDefinition<IAzureResourceDefinition>(group.Key, batch)))

src/Promitor.Core.Scraping/Configuration/Model/Metrics/BatchScrapeDefinition.cs

@@ -22,8 +22,9 @@ public class BatchScrapeDefinition<TResourceDefinition> where TResourceDefinitio
         /// <param name="groupedScrapeDefinitions">Scape definitions in the batch</param>
         public BatchScrapeDefinition(ScrapeDefinitionBatchProperties scrapeDefinitionBatchProperties, List<ScrapeDefinition<TResourceDefinition>> groupedScrapeDefinitions)
         {
-            Guard.NotNull(groupedScrapeDefinitions, nameof(scrapeDefinitionBatchProperties));
             Guard.NotNull(groupedScrapeDefinitions, nameof(groupedScrapeDefinitions));
+            Guard.NotLessThan(groupedScrapeDefinitions.Count, 1, nameof(groupedScrapeDefinitions));
+            Guard.NotNull(scrapeDefinitionBatchProperties, nameof(scrapeDefinitionBatchProperties));
 
             ScrapeDefinitionBatchProperties = scrapeDefinitionBatchProperties;
             ScrapeDefinitions = groupedScrapeDefinitions;

src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinition.cs

@@ -95,7 +95,7 @@ public ScrapeDefinition(
             return AzureMetricConfiguration?.Aggregation?.Interval;
         }
 
-        public ScrapeDefinitionBatchProperties BuildPropertiesForBatch() { 
+        public ScrapeDefinitionBatchProperties BuildScrapingBatchInfo() { 
             return new ScrapeDefinitionBatchProperties(
                 this.AzureMetricConfiguration,
                 this.LogAnalyticsConfiguration,

src/Promitor.Integrations.AzureMonitor/Configuration/AzureMonitorMetricBatchScrapeConfig.cs

@@ -4,7 +4,7 @@ namespace Promitor.Integrations.AzureMonitor.Configuration
 {
     public class AzureMonitorMetricBatchScrapeConfig
     {
-        public bool Enabled { get; set; }
+        public bool Enabled { get; set; } = false;
         public int MaxBatchSize { get; set; }
         public string AzureRegion { get; set; } = "eastus"; // Batch scrape endpoints are deployed by region 
     }

src/Promitor.Integrations.AzureMonitor/Extensions/MetricResultExtension.cs

@@ -1,12 +1,12 @@
-using System;
-using System.Text.RegularExpressions;
 using Azure.Monitor.Query.Models;
 
 namespace Promitor.Integrations.AzureMonitor.Extensions
 {
     public static class MetricResultExtension 
     {   
-        // hacky to to get resource ID since it's not available directly through the SDK model
+        /// <summary>
+        ///     hacky to to get resource ID since it's not available directly through the SDK model, because the MetricResult model does not have the ResourceID attribute that comes with Response JSON 
+        /// </summary>
         public static string ParseResourceIdFromResultId(this MetricResult metricResult) 
         {
             return ExtractResourceId(metricResult.Id);

src/Promitor.Integrations.AzureMonitor/HttpPipelinePolicies/ModifyOutgoingAzureMonitorRequestsPolicy.cs

@@ -9,6 +9,9 @@
 using Microsoft.Extensions.Logging;
 
 namespace Promitor.Integrations.AzureMonitor.HttpPipelinePolicies{
+    /// <summary>
+    ///     Work around to make sure range queries work properly. <see cref="https://github.com/Azure/azure-sdk-for-net/issues/40047">
+    /// </summary>
     public class ModifyOutgoingAzureMonitorRequestsPolicy : HttpPipelinePolicy
     {   
         private readonly ILogger _logger;