remove some more logging + add null checks

src/Promitor.Core.Scraping/Batching/AzureResourceDefinitionBatching.cs

@@ -1,5 +1,6 @@
 using System.Collections.Generic;
 using System.Linq;
+using GuardNet;
 using Promitor.Core.Contracts;
 using Promitor.Core.Scraping.Configuration.Model.Metrics;
 
@@ -17,18 +18,24 @@ public static class AzureResourceDefinitionBatching
         /// </summary>
         public static List<BatchScrapeDefinition<IAzureResourceDefinition>> GroupScrapeDefinitions(IEnumerable<ScrapeDefinition<IAzureResourceDefinition>> allScrapeDefinitions, int maxBatchSize) 
         {
+            Guard.NotNull(allScrapeDefinitions, nameof(allScrapeDefinitions));
+            Guard.NotLessThan(allScrapeDefinitions.Count(), 1, nameof(allScrapeDefinitions));
+
             return  allScrapeDefinitions.GroupBy(def => def.BuildScrapingBatchInfo()) 
                         .ToDictionary(group => group.Key, group => group.ToList()) // first pass to build batches that could exceed max 
                         .ToDictionary(group => group.Key, group => SplitScrapeDefinitionBatch(group.Value, maxBatchSize)) // split to right-sized batches 
                         .SelectMany(group => group.Value.Select(batch => new BatchScrapeDefinition<IAzureResourceDefinition>(group.Key, batch)))
                         .ToList(); // flatten 
         }
 
-    /// <summary>
+        /// <summary>
         /// splits the "raw" batch according to max batch size configured
         /// </summary>
         private static List<List<ScrapeDefinition<IAzureResourceDefinition>>> SplitScrapeDefinitionBatch(List<ScrapeDefinition<IAzureResourceDefinition>> batchToSplit, int maxBatchSize) 
         {
+            Guard.NotNull(batchToSplit, nameof(batchToSplit));
+            Guard.NotLessThan(batchToSplit.Count(), 1, nameof(batchToSplit));
+
             int numNewGroups = ((batchToSplit.Count - 1) / maxBatchSize) + 1;
 
             return Enumerable.Range(0, numNewGroups)

src/Promitor.Integrations.AzureMonitor/AzureMonitorQueryClient.cs

@@ -133,7 +133,6 @@ public async Task<List<ResourceAssociatedMeasuredMetric>> BatchQueryMetricAsync(
 
             // Get the most recent metric
             var metricResultsList = await _metricsBatchQueryClient.GetRelevantMetricForResources(resourceIds, metricName, metricNamespace, MetricAggregationTypeConverter.AsMetricAggregationType(aggregationType), closestAggregationInterval, metricFilter, metricDimensions, metricLimit, startQueryingTime, _azureMonitorIntegrationConfiguration, _logger);
-            _logger.LogWarning("Azure monitor has returned {ResultsCount} results for metric {MetricName}", metricResultsList.Count, metricName); 
 
             //TODO: This is potentially a lot of results to process in a single thread. Think of ways to utilize additional parallelism
             return metricResultsList

src/Promitor.Integrations.AzureMonitor/Extensions/AzureMonitorQueryTasks.cs

@@ -84,7 +84,6 @@ public static async Task<List<MetricResult>> GetRelevantMetricForResources(this
 
             var metricsBatchQueryResponse = await metricsClient.QueryResourcesAsync(resourceIdentifiers, [metricName], metricNamespace, queryOptions);
             var metricsQueryResults = metricsBatchQueryResponse.Value;
-            logger.LogWarning("Got response");
             return metricsQueryResults.Values
                 .Select(result => GetRelevantMetricResultOrThrow(result, metricName))
                 .ToList();

src/Promitor.Integrations.AzureMonitor/HttpPipelinePolicies/ModifyOutgoingAzureMonitorRequestsPolicy.cs

@@ -53,9 +53,7 @@ private void ModifyDateTimeParam(List<string> paramNames, HttpMessage message)
                 message.Request.Uri.Query = query.ToString();
             } else {
                 _logger.LogWarning("Failed to modify parameters {Parms}", string.Join("and ", paramNames));
-            }
-            _logger.LogWarning("Final url is {URI}", message.Request.Uri.ToString());
-
+            }           
         }
     }
 }