feat: Provide support for batch scraping #2640
hkfgoci-code.yml
on: pull_request
Verify Codebase
1m 14s
Code Quality (R#)
2m 27s
Annotations
1 error, 10 warnings, and 10 notices
|
Code Quality (R#)
Issues found.
|
|
Code Quality (R#):
src/Promitor.Core/Extensions/MeasureMetricExtensions.cs#L9
"[InvalidXmlDocComment] Parameter 'measuredMetric' has no matching param tag in the XML comment for Promitor.Core.Extensions.MeasuredMetricExtensions.WithResourceIdAssociation (but other parameters do)" on /home/runner/work/promitor/promitor/src/Promitor.Core/Extensions/MeasureMetricExtensions.cs(9,401)
|
|
Code Quality (R#):
src/Promitor.Core.Scraping/AzureMonitorScraper.cs#L143
"[PossibleNullReferenceException] Possible 'System.NullReferenceException'" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/AzureMonitorScraper.cs(143,9350)
|
|
Code Quality (R#):
src/Promitor.Core.Scraping/Batching/AzureResourceDefinitionBatching.cs#L3
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/Batching/AzureResourceDefinitionBatching.cs(3,53)
|
|
Code Quality (R#):
src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatchProperties.cs#L98
"[ConvertTypeCheckToNullCheck] Use null check instead of a type check succeeding on any not-null value" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatchProperties.cs(98,4134)
|
|
Code Quality (R#):
src/Promitor.Core.Scraping/Configuration/Serialization/v1/Model/MetricsDeclarationV1.cs#L2
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/Configuration/Serialization/v1/Model/MetricsDeclarationV1.cs(2,34)
|
|
Code Quality (R#):
src/Promitor.Core.Scraping/LogAnalyticsScraper.cs#L4
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/LogAnalyticsScraper.cs(4,67)
|
|
Code Quality (R#):
src/Promitor.Core.Scraping/LogAnalyticsScraper.cs#L7
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/LogAnalyticsScraper.cs(7,131)
|
|
Code Quality (R#):
src/Promitor.Integrations.AzureMonitor/AzureMonitorQueryClient.cs#L26
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/promitor/promitor/src/Promitor.Integrations.AzureMonitor/AzureMonitorQueryClient.cs(26,885)
|
|
Code Quality (R#):
src/Promitor.Integrations.AzureMonitor/AzureMonitorQueryClient.cs#L305
"[RedundantNameQualifier] Qualifier is redundant" on /home/runner/work/promitor/promitor/src/Promitor.Integrations.AzureMonitor/AzureMonitorQueryClient.cs(305,20047)
|
|
Code Quality (R#):
src/Promitor.Integrations.AzureMonitor/Configuration/AzureMonitorMetricBatchScrapeConfig.cs#L1
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/promitor/promitor/src/Promitor.Integrations.AzureMonitor/Configuration/AzureMonitorMetricBatchScrapeConfig.cs
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L12
"[ArrangeNamespaceBody] Convert to file-scoped namespace" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(12,317)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L23
"[MemberCanBeProtected.Global] Method 'CreatePromitorWebHost' can be made protected" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(23,880)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L28
"[SuggestVarOrType_SimpleTypes] Use 'var' (simple types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(28,1260)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L54
"[MemberCanBePrivate.Global] Method 'DetermineHttpPort' can be made private" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(54,2323)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L66
"[SuggestVarOrType_BuiltInTypes] Use 'var' (built-in types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(66,2766)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L79
"[SuggestVarOrType_BuiltInTypes] Use 'var' (built-in types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(79,3190)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L12
"[ArrangeNamespaceBody] Convert to file-scoped namespace" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(12,306)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L18
"[MemberCanBeProtected.Global] Property 'Configuration' can be made protected" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(18,446)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L53
"[VirtualMemberNeverOverridden.Global] Virtual method 'CreateSerilogConfiguration' is never overridden" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(53,1991)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L75
"[VirtualMemberNeverOverridden.Global] Virtual method 'EnrichTelemetry' is never overridden" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(75,3329)
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
test-results
Expired
|
310 KB |
|