bugfixes

- fix more defer panics
- don't create empty files

pkg/adssl/adssl.go

@@ -122,12 +122,13 @@ func getCaCert(endpoint string, username string, password string) (string, error
 
 	crtURL := "https://" + endpoint + "/certsrv/certnew.cer?ReqID=CACert&Enc=b64&Mode=inst&" + renewal
 	resp, err = makeRequest(crtURL, username, password, "")
-	defer resp.Body.Close()
 
 	if err != nil {
 		return "", fmt.Errorf("failed to request %s: %v", crtURL, err)
 	}
 
+	defer resp.Body.Close()
+
 	dataInBytes, err = ioutil.ReadAll(resp.Body)
 	return string(dataInBytes), err
 
@@ -170,12 +171,12 @@ func genCertRequest(csr string, endpoint string, username string, password strin
 func fetchCertResult(resURL string, username string, password string) (string, error) {
 	resp, err := makeRequest(resURL, username, password, "")
 
-	defer resp.Body.Close()
-
 	if err != nil {
 		return "", fmt.Errorf("failed to fetch resulting cert: %v", err)
 	}
 
+	defer resp.Body.Close()
+
 	dataInBytes, err := ioutil.ReadAll(resp.Body)
 	return string(dataInBytes), err
 }

pkg/gobblah/gobblah.go

@@ -74,6 +74,9 @@ func (c *Config) Run(args []string) error {
 			var res Result
 			var err error
 			res.Cacrt, res.Tlskey, res.Tlscrt, err = adssl.CreateCertificates(c.Endpoint, c.Username, c.Password, c.Hosts)
+			if err != nil {
+				log.Fatal(err)
+			}
 			if ctx.Bool("k8s-secret") {
 				kubernetes.OutputSecret(res.Cacrt, res.Tlskey, res.Tlscrt)
 			} else {