bugfix: more safety when parsing table IDs and table entity IDs, also accept table IDs in legacy and newer formats #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
force-pushed
the
bugfix/table-id-parsing
branch
2 times, most recently
from
13d868e to
7ffcb6e
Compare
…n ID string with AzureRM provider, and also accept table IDs in both legacy and newer formats
manicminer
force-pushed
the
bugfix/table-id-parsing
branch
from
7ffcb6e to
ed004ee
Compare
Merged
9 tasks
…p/go-azure-sdk/sdk` and v0.66.2 of `github.com/hashicorp/go-azure-sdk/resource-manager`
…upport `text/xml`
…p/go-azure-sdk/sdk` and `github.com/hashicorp/go-azure-sdk/resource-manager`
manicminer
force-pushed
the
bugfix/table-id-parsing
branch
from
dca8983 to
9e9387a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note in the AzureRM provider we used to have table IDs in the format:
but migrated to the format:
The API uses both forms for different operations, for this reason and to avoid further state migrations in the provider, it's helpful to accept both formats, whilst outputting the newer form in the latest SDK.
Also, for consistency, use
application/xmlcontent type for XML payloads instead oftext/xml(although the API seems to support both).Also also, updating go-azure-sdk to v0.20240227.1172434 to include:
http.Request.ContentLengthfield instead ofContent-Lengthheader when building the signed assertion for shared key authorizer hashicorp/go-azure-sdk#906