Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user or admin to set the number of lines of context when doing a diff #13

Closed
lscarval opened this issue Jan 7, 2016 · 4 comments

Comments

@lscarval
Copy link

lscarval commented Jan 7, 2016

The default behavior is to show the diff and 3 lines of context only.

For most of the commits 3 lines are not enough. Many times, it is difficult to grasp the change with such a small diff context.

Please, consider adding a some sort of visual setting that allows the user to set the number of context lines.

If that's not possible, than consider adding an option to set something in a config file that the Gerrit admin can set, which would still be fixed, but could be set at a higher number.

Thanks a lot!

@tomaswolf
Copy link
Owner

That's Gitblit core functionality. As far as I see, Gitblit always uses the (default) seting of 3 lines.

A visual way to change that would have to be done in Gitblit itself -- unless I'm missing something, it doesn't have that yet. Maybe a user preference -- but it looks like I'll have to revisit user preferences anyway; looks like they don't save...

A configuration setting would be a much less invasive change that I could do in the Gerrit plugin itself, but it's sub-optimal, as it would be a global setting for everyone everywhere.

I'll see what I can do with reasonable effort.

@tomaswolf
Copy link
Owner

You might want to give release v2.12.162.2 a try. It re-uses the Gerrit preference for the number of context lines in Gitblit diffs.

If it works for you, I'll promote that release from "pre-release" to a proper release.

@tomaswolf
Copy link
Owner

I guess no news is good news. Promoted the release.

@lscarval
Copy link
Author

Thanks. It looks fine to me
On Jan 21, 2016 3:24 PM, "tomaswolf" [email protected] wrote:

Closed #13 #13.


Reply to this email directly or view it on GitHub
#13 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants