Merging aviyan-dev to main (2024-04-04) #52
Conversation
…le docker build statement
…1); Edited the echo \[�]633;A�\]\[\e]0;\u@\h: \w\a\]${debian_chroot:+($debian_chroot)}\[\033[01;32m\]\u@\h\[\033[00m\]:\[\033[01;34m\]\w\[\033[00m\]\$ \[�]633;B�\] message to check if it has the character '>'
…readonly commands (copy-readonly.sh not exist)
…d do-make command (not found)
…ed mv to trash_dir on cell34
…JUPYTER to False; Replaced wrapup() with driver.quit() [Webdriver object is not callable]; --first option selects the first N testfiles in alphabetical order; Added termination of script for invalid credentials; Added constant: SELENIUM_SLEEP to pause driver until all the cells are executed
…cripts from archive
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9157706 | Triggered | GitHub Access Token | e86ece4 | tests/summary_stats.bash | View secret |
| 9157706 | Triggered | GitHub Access Token | a59a9c0 | tests/summary_stats.bash | View secret |
| 9157706 | Triggered | GitHub Access Token | a59a9c0 | Dockerfile | View secret |
| 9157706 | Triggered | GitHub Access Token | a59a9c0 | tests/summary_stats.bash | View secret |
| 9401309 | Triggered | GitHub Access Token | a59a9c0 | Dockerfile | View secret |
| 9401309 | Triggered | GitHub Access Token | e86ece4 | tests/summary_stats.bash | View secret |
| 9401309 | Triggered | GitHub Access Token | a59a9c0 | tests/summary_stats.bash | View secret |
| 9401309 | Triggered | GitHub Access Token | f15c10a | Dockerfile | View secret |
| 9425889 | Triggered | RSA Private Key | f15c10a | tests/scrappycito.pem | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
What's with this (i.e., return of the t_')? commit d6aa35c |
|
This needs more work before it can be merged: there is no noticeable change in improvement and 'mv -f' should not be used for cleanup. Please review my instructions carefully about the test work (e.g., rename-with-file-date). More details will be sent via email. *** It is important to maintain a checklist of requested features, etc. to avoid the need to repeated email, etc.. |
Previously, t_ suffix had been used for variables of print_test_array() of batspp_report.py. One of the commits converted the variable with t_ suffix to a simpler variable name (commit cdba7a9) [e.g. t_rate -> rate, t_name -> test_name]. However, the change was reverted back in this commit, as it was a bit confusing to identify the variables with same names for other fixes, such as working with run_batspp() function. |
…ories; Commented implementation to avoid the use of mv -f
…ts for cd-real-dir [CELL_11]; Added testuserpath alias to replace /home/USER -> USER_PATH/ [CELL_4]; Added pwd with testuser to show the working of cd-like commands [C10-C12]
… to replace /home/USER -> USER_PATH/; Commented all instance of trash_dir and mv -f to trash_dir
…Rework with temp_dir to use rename-with-file-date; Commented ln-symbolic command as the link with same name exists (For demonstration)
…mented mv -f to trash_dir at the end of test
|
Thanks for the reminder regarding rename-with-file-date. This approach was dropped earlier as "pwd" or "echo" would return the original value of temp_dir variable. The commits above removes all occurrence of trash_dir and mv -f to trash_dir and uses rename-with-file-date when initializing the temp_dir. |
…ttern matching of timestamps (Cell 9); Redefined the test for perlgrep command using 'conditional-echo' (Cell 23)
… rename-with-file-date (Cell 36); Updated the comment for do_rcsdiff [Permission Denied)] (Cell 18)
…more than 1 line (Cell 15) & path to mezcla (Cell 16); Used conditional-echo commands for python-lint, python-import-path tests, python-module-version (Cell 17, 18, 24, 26, 27, 28); Test for url-path uses path to tests/batspp_report.py (Cell 61); Commented final instance of trash_dir use (Cell 65)
This includes the fix for the notebook automation script; automate_notebook.py (formely, automate_ipynb.py and its experimental versions).