-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airflow-dbt-python v1.0.0 #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
force-pushed
the
feat/v1.0.0
branch
from
February 17, 2023 17:32
97e4ae7
to
7583759
Compare
tomasfarias
force-pushed
the
feat/v1.0.0
branch
from
February 19, 2023 19:37
7583759
to
19976f9
Compare
tomasfarias
force-pushed
the
feat/v1.0.0
branch
from
February 19, 2023 21:09
6007ab8
to
1654786
Compare
dbt-core v1.4 broke us. It's unclear why, but as this feature is not well documented, tested, or even fully ironed out yet, I'm allowing this test to fail. My hope is that as development of dbt-library advances, there will be a cleaner way to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the last few months I've been working on a heavy refactoring of the internals of airflow-dbt-python. Life has consistently gotten in the way, but the finish line is now clear. The main goal of the refactor was formalize the responsibilities of operators, hooks, and utilities to allow me to commit to a v1.0.0 release:
airflow-dbt-python operators:
airflow-dbt-python hooks:
airflow-dbt-python utilities:
Moreover, besides the items in the Roadmap (see the bottom), the release of v1.0.0 signifies I have no more ideas for features to implement in airflow-dbt-python. I'll be happy to resume maintenance of the issue board which has gone a bit stale at this point, and I'll rely on the community to propose new ideas for features to develop.
Due to the sheer size of this refactor, once merged I'll make a beta release for version 1.0.0. I encourage folks to try out the beta version and report any issues if they can.
Changes:
upload
anddownload
.URL
class for all URL-like arguments.DbtRemoteGitHook
to utilize git repositories as remotes.Breaking changes:
Roadmap (things that I didn't get to do but may do in the future):
asyncio
which unfortunately dbt does not currently use (dbt is thread-based). It may be possible to use deferrable operators with anasyncio
dbt adapter, but I have not had the time to turn these ideas into anything concrete.