Skip to content
This repository has been archived by the owner on Jun 9, 2021. It is now read-only.

Wrong PULL_REQUEST_URL #82

Closed
eratolekov opened this issue Nov 6, 2015 · 4 comments
Closed

Wrong PULL_REQUEST_URL #82

eratolekov opened this issue Nov 6, 2015 · 4 comments
Labels
bug

Comments

@eratolekov
Copy link

Hi Tomas

Thanks for plugin!

If name of repo in Bitbucket Server contains spaces, PULL_REQUEST_URL contains these spaces too.
Wrong PULL_REQUEST_URL

https://example.com/projects/PROJ/repos/Repo Name with Spaces/pull-requests/2

The correct PULL_REQUEST_URL is

https://example.com/projects/PROJ/repos/repo-name-with-spaces/pull-requests/2
@tomasbjerre tomasbjerre added the bug label Nov 6, 2015
@eratolekov eratolekov mentioned this issue Nov 6, 2015
Closed
tomasbjerre added a commit that referenced this issue Nov 6, 2015
@tomasbjerre
Replacing spaces with dashes in PULL_REQUEST_URL #82
1e2d237 
 * Was evaluating to wrong URL if repo name included spaces.
tomasbjerre added a commit that referenced this issue Nov 6, 2015
@tomasbjerre
Replacing spaces with dashes in PULL_REQUEST_URL #82
e75770f 
 * Was evaluating to wrong URL if repo name included spaces.
@tomasbjerre
Copy link
Owner

This should be fixed now if you update the plugin

@eratolekov
Copy link
Author

Hi Tomas

I guess better to use getSlug() instead of getName().

@tomasbjerre
Copy link
Owner

Yes, feel free to submit a pull request for that :)

@tomasbjerre tomasbjerre reopened this Nov 8, 2015
@tomasbjerre
Copy link
Owner

Im opening issue again. Should use getSlug to fix this correctly.

tomasbjerre added a commit that referenced this issue Nov 9, 2015
@tomasbjerre
Fixing PULL_REQUEST_URL-bug correctly with getSlug #82
c19f72f
tomasbjerre added a commit that referenced this issue Nov 9, 2015
@tomasbjerre
Fixing PULL_REQUEST_URL-bug correctly with getSlug #82
1d515f7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomasbjerre @eratolekov