Skip to content
This repository has been archived by the owner on Jun 9, 2021. It is now read-only.

Wrong url built when using & in branch names #76

Closed
nikolaykolev opened this issue Oct 15, 2015 · 2 comments
Closed

Wrong url built when using & in branch names #76

nikolaykolev opened this issue Oct 15, 2015 · 2 comments
Labels
bug

Comments

@nikolaykolev
Copy link

When a & is used in branch name and you have a trigger which sends a request to somewhere with ${PULL_REQUEST_FROM_ID} or ${PULL_REQUEST_FROM_BRANCH} the symbol & is not escaped. When this symbol is not escaped the http request has 1 more wrong GET param.
Example: branchName=some-fixes&more-fixes
built url: http://jenkins.asd.com/buildWithParam?branchname=some-fixes&more-fixes
In this case jenkins recognises 2 params instead of 1
should be: http://jenkins.asd.com/buildWithParam?branchname=some-fixes%26more-fixes
tomasbjerre added a commit that referenced this issue Oct 15, 2015
@tomasbjerre
Url encoding evaluated values when they are used in URL invocations #76
6925ea2
tomasbjerre added a commit that referenced this issue Oct 15, 2015
@tomasbjerre
Url encoding evaluated values when they are used in URL invocations #76
9a58b3f
@tomasbjerre
Copy link
Owner

Released now in Marketplace :) Open issue again if not solved!

@nikolaykolev
Copy link
Author

Thank you! :) I'll get in touch if we find other bugs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomasbjerre @nikolaykolev