Skip to content
This repository has been archived by the owner on Jun 9, 2021. It is now read-only.

Pull Request Trigger Firing Twice #37

Closed
RBeaudoin opened this issue Jun 19, 2015 · 4 comments
Closed

Pull Request Trigger Firing Twice #37

RBeaudoin opened this issue Jun 19, 2015 · 4 comments

Comments

@RBeaudoin
Copy link

I am using this add on to trigger a build when a pull request is submitted, using this config:

screen shot 2015-06-19 at 12 23 11 pm

It looks like on Pull Request creation my build is being triggered twice, and since it's only triggered via this plugin I'm assuming the plugin is making the POST request twice. If it's user config issue let me know what I need to change

@tomasbjerre
Copy link
Owner

You do want to also check the rescoped box. You current setup will not trigger if both source and target is changed at the exact same time. I should probably remove the rescoped box and have this behaviour as default.

The issue has been reported before, in #20 .

I would suggest that you have both from and to hash in the URL. And then check the log file of the notified system. To be absolutely certain that it gets notified twice.

Keep me posted :)

@tomasbjerre
Copy link
Owner

Updated means you will trigger on description or title change...

https://developer.atlassian.com/static/javadoc/stash.old-perms-pre-feb4/2.0.1/api/reference/com/atlassian/stash/event/pull/PullRequestUpdatedEvent.html

Do you really want to trigger a build for that?

@RBeaudoin
Copy link
Author

@tomasbjerre I can remove 'Updated' that makes sense. In fact we should add that link to the README here so folks understand what triggers what in Stash.

I'll do some debugging and see what is triggering twice

tomasbjerre added a commit that referenced this issue Jun 21, 2015
* Also adding logging that shows event name together with from and to hashes.
tomasbjerre added a commit that referenced this issue Jun 21, 2015
* Also adding logging that shows event name together with from and to hashes.
@tomasbjerre
Copy link
Owner

Closing this one, to clean the issue list a bit. Re-open if still occurring.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants